Refactor MeasureUnitParser and update related components
#6328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the dependency on `ZeroTrieSimpleAscii` in `MeasureUnitParser`, replacing it with `DataPayload` for better data handling. - Introduced new constructors for `MeasureUnitParser`, including a stable constructor and an unstable one that accepts a data provider. - Updated tests to directly instantiate `MeasureUnitParser` instead of using `ConverterFactory`. - Refactored `UnitsInfo` to replace `units_conversion_trie` with `conversion_info`, aligning with the new data structure. - Adjusted related components and tests to reflect these changes, ensuring consistency across the measurement unit parsing functionality.
younies
requested review from
sffc,
robertbastian,
Manishearth and
a team
as code owners
younies
commented
Mar 20, 2025
younies
commented
Mar 20, 2025
provider/source/src/units/info.rs
Outdated
| DataError::custom("Could not create ZeroTrie from units.json data") | ||
| .with_display_context(&e) | ||
| })?; | ||
| // TODO: now we need to create `MeasureUnitParser` in order to create the conversion info. how to do that ? |
There was a problem hiding this comment.
@robertbastian , @Manishearth
Now, in order to create the ConversionInfoV1, we need to have a measure unit parser, and measure unit parser is depending on UnitsInfoV1, how can I do that ?
There was a problem hiding this comment.
I don't understand the question: things can depend on each other just fine
Co-authored-by: Robert Bastian <[email protected]>
Co-authored-by: Robert Bastian <[email protected]>
robertbastian
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ZeroTrieSimpleAsciiinMeasureUnitParser, replacing it withDataPayloadfor better data handling.MeasureUnitParser, including a stable constructor and an unstable one that accepts a data provider.MeasureUnitParserinstead of usingConverterFactory.UnitsInfoto replaceunits_conversion_triewithconversion_info, aligning with the new data structure.