Update unit conversion to accept unit constant denominator #6199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds comprehensive tests for unit conversion scenarios including: - Conversion between units with constant denominators (e.g., liter-per-100-kilometer to mile-per-gallon) - Temperature conversions with offsets (celsius to fahrenheit) - Adds a new `from_integer` method to `IcuRatio` - Removes TODO comment blocking constant denominator unit tests
|
Changelog please (all PRs until the beta2 release should contain a changelog entry. In general it is best practice to do this anyway even after a release.) |
|
beta2 is released, the changelog entry should be moved to the unreleased section (in #6203, approve and merge that first) |
younies
changed the title
Manishearth
approved these changes
Mar 4, 2025
Manishearth
reviewed
Mar 4, 2025
| @@ -8,6 +8,10 @@ | |||
| - `icu_collections` | |||
| - Remove some panics from `CodePointTrie`, which should no longer pull in panic machinery even with arithmetic panics enabled for lookup (unicode-org#6204) | |||
| - Data model and providers | |||
| - `icu_experimental` | |||
| - `dimension` | |||
| - `units` | |||
There was a problem hiding this comment.
just under units not dimension/units
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
from_integermethod toIcuRatio