🆕 🎉 First launch of UNICEF Coach Cards for O.S. Mentorship #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iperdomo
reviewed
Dec 30, 2021
| docker: | ||
| - image: cimg/ruby:3.0 | ||
| steps: | ||
| - run: gem install htmlbeautifier |
There was a problem hiding this comment.
I would suggest that instead of tidying the HTML, we may want to minify it. Hugo has the option to minify the output.
Note that you can also minify the final HTML output to /public by running
hugo --minify
https://gohugo.io/hugo-pipes/minification/
iperdomo
reviewed
Dec 30, 2021
iperdomo
reviewed
Dec 30, 2021
justjwheelin
added a commit
that referenced
this pull request
Dec 30, 2021
Warnings identified by @iperdomo in PR #2. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]>
justjwheelin
added a commit
to unicef/inventory
that referenced
this pull request
Dec 30, 2021
Warnings identified by @iperdomo in PR unicef/coach#2. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]>
justjwheelin
added a commit
to unicef/drone-4sdgtoolkit
that referenced
this pull request
Dec 30, 2021
Warnings identified by @iperdomo in PR unicef/coach#2. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]>
justjwheelin
added a commit
to sustainers/design
that referenced
this pull request
Dec 30, 2021
Warnings identified by @iperdomo in PR unicef/coach#2. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]>
justjwheelin
added a commit
to unicef/inventory
that referenced
this pull request
Dec 30, 2021
Warnings identified by @iperdomo in PR unicef/coach#2. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]>
justjwheelin
added a commit
to unicef/drone-4sdgtoolkit
that referenced
this pull request
Dec 30, 2021
Warnings identified by @iperdomo in PR unicef/coach#2. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]>
justjwheelin
added a commit
to sustainers/design
that referenced
this pull request
Dec 30, 2021
Warnings identified by @iperdomo in PR unicef/coach#2. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]>
justjwheelin
added a commit
that referenced
this pull request
Dec 30, 2021
Warnings identified by @iperdomo in PR #2. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]>
justjwheelin
force-pushed
the
convert/hugo-site
branch
from
673b5dd to
e1f91e0
Compare
justjwheelin
added a commit
to unicef/inventory
that referenced
this pull request
Dec 30, 2021
Warnings identified by @iperdomo in PR unicef/coach#2. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]>
justjwheelin
added a commit
to unicef/drone-4sdgtoolkit
that referenced
this pull request
Dec 30, 2021
Warnings identified by @iperdomo in PR unicef/coach#2. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]>
justjwheelin
added a commit
to sustainers/design
that referenced
this pull request
Dec 30, 2021
Warnings identified by @iperdomo in PR unicef/coach#2. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]>
This commit converts this conceptual repository into a prototype project. This uses the Hugo static site generator to create a quick website for evaluating and rating the performance of UNICEF portfolio companies in a report card-like setting. It uses the UNICEF Inventory Hugo theme to accomplish this. Related to #1. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]> :bug: :wrench: ci: Fix Shellcheck warnings in deploy script Warnings identified by @iperdomo in PR #2. Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]> :alembic: :wrench: ci: Use verbose HTML-Proofer error messages in logs This commit updates the CircleCI Hugo orb to v1.3.0. This change incorporates changes I made upstream in the Hugo orb so HTML-Proofer will print verbose error messages if there is a failure. Currently, error messages are suppressed in the CircleCI logs and this makes debugging difficult. Additionally, the `asciidoc` binary is now included in the container image used in this build, so specifying the Asciidoc parameter in the CircleCI config is no longer necessary. Related GitHub Pull Requests: * CircleCI-Public/hugo-orb#47 * CircleCI-Public/hugo-orb#48 * CircleCI-Public/hugo-orb#50 Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <[email protected]>
justjwheelin
force-pushed
the
convert/hugo-site
branch
from
2322dad to
a471246
Compare
|
I merged unicef/inventory-hugo-theme#44, so this can move forward. It will likely need tweaking, but better to iterate over time than hold off for the perfect implementation. Merging, and will begin working on this more in the coming weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit converts this conceptual repository into a prototype
project. This uses the Hugo static site generator to create a quick
website for evaluating and rating the performance of UNICEF portfolio
companies in a report card-like setting. It uses the UNICEF Inventory
Hugo theme to accomplish this.
Related to #1.