Add extra channel info #1332
Add extra channel info #1332
Conversation
wchen342
force-pushed
the
about-patch
branch
2 times, most recently
from
c258740 to
c483b4c
Compare
There was a problem hiding this comment.
- Instead of overriding extra channel info, can we simply append
(ungoogled-chromium)? - Alternatively, would it be easier to patch the HTML file as suggested here? "about" (settings/help) should state this is ungoogled cromium #1303 (comment). Or is this not cross-platform enough?
| std::string modifier; | ||
|
|
||
| - char* env = getenv("CHROME_VERSION_EXTRA"); | ||
| + char* env = "Ungoogled Chromium"; |
There was a problem hiding this comment.
This would prevent reading the environment variable CHROME_VERSION_EXTRA.
There was a problem hiding this comment.
This is what Fedora uses in their chromium package so I just adapted it. Is there any actual a use case for CHROME_VERSION_EXTRA? Although appending shall be possible since the extra info is just a string.
would it be easier to patch the HTML file as suggested
The change here modifies the string shown on both chrome://settings/help and chrome://version at the same time. Editing HTML doesn't have that effect I think.
There was a problem hiding this comment.
This is what Fedora uses in their chromium package so I just adapted it. Is there any actual a use case for CHROME_VERSION_EXTRA? Although appending shall be possible since the extra info is just a string.
Debian also sets it to indicate the build distribution & running distribution. I don't want to break that behavior.
Actually, could we just set (ungoogled-chromium) only if no extra channel info is provided at all? I don't want to force users to have this string if they don't want it.
| return base::UTF16ToASCII(channel); | ||
| #else | ||
| - return std::string(); | ||
| + return std::string("Ungoogled Chromium"); |
There was a problem hiding this comment.
We should probably test this on Windows to make sure it won't override the configured channel info.
There was a problem hiding this comment.
I cannot compile the WIndows version. Who is the maintainer of Win repo? Maybe he can help testing this.
There was a problem hiding this comment.
I'm maintaining the Windows repo. I can test this for you.
|
An alternative option would be to change "Official Build" in This wouldn't require any platform-specific changes, aligns more with the linked issue, and might clear some confusion in issues with people thinking they are running an 'official' build of ungoogled-chromium. |
|
Won't that only apply when |
|
That's true! I guess "Developer Build" could also be changed. Maybe have them named something like "ungoogled-chromium release build/ungoogled-chromium dev build"? |
|
Yeah that can be a good idea. What does @Eloston think? |
|
Sure, I don't mind changing the |
wchen342
force-pushed
the
about-patch
branch
from
c483b4c to
eef8d18
Compare
wchen342
force-pushed
the
about-patch
branch
from
eef8d18 to
91e9cad
Compare
|
The patch has been updated to append |
Add "Ungoogled Chromium" as extra channel infomation. Solves #1303.
*nix version is tested on Fedora. Windows version is untested.