Changelist sidebar two elements active / selected when using tabs with same model

[alfonsrv]

What version of Unfold are you using? 0.62.0

What version of Django are you using? 5.2.x

Are you able to replicate the bug in the demo site? https://demo.unfoldadmin.com/en/admin/formula/driver/crispy-form

Describe your issue

When using tabs the first defined model instance is always selected in the sidebar. So it's active even when a different model is selected, resulting in two active sidebar items.

[lukasvinclav]

Currently, Unfold has basic implementation how to recognise which items in the navigation are active. You can have custom links in various navigations(sidebar & tabs) and at the top of that filters which can have an impact on if the link is active or not.

For that reason, you can define active callback which will resolve by using your custom logic if link is active or not. I updated demo site which works fine now. You can check the implmentation of the callback here unfoldadmin/formula@b29e3f0

Let me know. If you have any other question.

[alfonsrv]

I don't believe this works as expected. When I select Bar in the sidebar, the Foo entry is still marked in the navigation, even though the active callback returns False (I checked with pdb)

Also I feel like for admin: scoped links the permissions should be evaluated automatically if not specified otherwise. Typing them out for each navigation item creates a lot of overhead.

                "items": [
                    {
                        "title": "Foo",
                        "icon": "contacts_product",
                        "link": reverse_lazy("admin:core_foo_changelist"),
                        "permission": lambda request: request.user.has_perm('core.view_foo'),
                        "active": lambda request: reverse("admin:core_foo_changelist") in request.path,
                    }, {
                        "title": "Bar",
                        "icon": "emergency",
                        "link": reverse_lazy("admin:core_bar_changelist"),
                        "permission": lambda request: request.user.has_perm('core.view_boo'),
                        "active": lambda request: reverse("admin:core_bar_changelist") in request.path,
                    },

[lukasvinclav]

I just did a quick test on demo site with lambda functions and it was working. Right now, I'm not sure what can be wrong. I checked your code and it looks okay to me. Following code lambda request: False must always make navigation item inactive. If this is not working for you, I need to get some minimal code which can reproduce the issue.

Regarding permissions, I understand that it can be verbose to manually specify permissions but right now the navigation does not know that item is pointing at the specific model. What you are suggesting would be large refactor of the navigation evaluation and introduction of two more string params app and model. We need to take into consideration query params and fragment as well. Current implementation is not perfect but it covers most of the use cases. Of course, I'm open to some suggestions, ideally with defined concept.

PS: Maybe you can try following syntax to remove some visual noise: lambda r: r.user.has_perm("core.view_boo").

[lukasvinclav]

One more thing, to speed up debugging process, you can reach me on Discord. Link is available at unfoldadmin.com or here on GitHub in README page.

[alfonsrv]

There you go – hope this helps: https://github.com/alfonsrv/unfold-test