Upgrade jest to version 24.0.0 #587
Conversation
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
|
Looks like a problem with jest's babel integration, does anyone have an idea? |
|
I can try to take a look. |
|
@papandreou it could look like we are behind on Babel somewhere: My guess is that we will be forced to upgrade to Babel 7 soon. |
|
There is a breaking change around presets and Babel 7
See https://github.com/facebook/jest/blob/master/CHANGELOG.md#2400 |
|
Ah, I thought we were fully up to date with that whole toolchain. I think that explains all the trouble I had with getting selective |
papandreou
force-pushed
the
depfu/update/npm/jest-24.0.0
branch
from
20f02cc to
b1df7ba
Compare
…t deprecation warning" This reverts commit 8304148.
|
I've made some progress by upgrading to babel 7 and switching to |
This is an attempt to fix this error:
Variable undefined in strict mode
at build/test/promisePolyfill.js:5:3
ReferenceError: Variable undefined in strict mode
at Global code (build/test/promisePolyfill.js:5:3)
Inspired by: https://stackoverflow.com/questions/46271369/remove-global-use-strict-from-babel-preset-env
papandreou
force-pushed
the
depfu/update/npm/jest-24.0.0
branch
from
1bb21c3 to
a6d36ee
Compare
…njecting 'use strict';
|
Hmm, I have all the tests passing locally now, also |
|
Seems like babel/babel#8947 is all that's needed now. |
| @@ -30,6 +30,7 @@ build: build/lib build/test build/externaltests | |||
| ${TARGETS}: build | |||
| ./node_modules/.bin/rollup --config rollup.config.js --sourcemap --format umd --name weknowhow.expect -o unexpected.js build/lib/index.js | |||
| sed -e "s/Symbol.iterator in Object/typeof Symbol === 'function' \&\& Symbol.iterator in Object/;" -i unexpected.js | |||
| sed -e "s/Array\.from/Array.prototype.slice.call/g;" -i unexpected.js | |||
There was a problem hiding this comment.
For the record, I'm not suggesting that we make this change -- it breaks our source maps. I don't want to merge it until this has been sorted out upstream.
| "@babel/preset-env", | ||
| { | ||
| } | ||
| ] |
There was a problem hiding this comment.
You can just write "@babel/preset-env", no need for the options syntax.
There was a problem hiding this comment.
Yeah, there has been a lot of changes back and forth. I'll clean it up when it's ready to merge.
|
Superseeded by later PR. |
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ jest (^23.0.0 → ^24.0.0) · Repo · Changelog
Release Notes
24.0.0 (from changelog)
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands