Skip to content

Acp regions #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Acp regions #10

wants to merge 8 commits into from

Conversation

Levia
Copy link
Contributor

@Levia Levia commented Oct 23, 2019

Description

  • New endpoint for countries service that returns countries within ACP regions only. Can also filter by acp_region parameter.
  • Amend biopama endpoint to allow filtering by acp_region

Notes

⚠️ Tests have been skipped and db submodule not updated as the newest migrations labeled as [5.0] (following the recent PP Rails upgrade) will throw an error on Travis with the current version of the gems in the PP-API. More work is required on this to update the ActiveRecord gems and related.
Overall migrations are fine if run within the main PP repo.
⚠️ pp-db related work and migrations are required
⚠️ Public documentation for acp countries endpoint is missing on purpose (need to check with PaP if it needs to be added first)

@lucacug
Copy link
Contributor

lucacug commented Oct 31, 2019

Works fine!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants