fix: allow minimatch 9 or 10 #276

jribbens · 2025-03-31T12:01:54Z

minimatch 10 drops support for node < 20
fixes #275

Summary by CodeRabbit

Chores
- Updated dependency version constraints for minimatch to support a broader range of library versions, enhancing overall compatibility.
- Introduced a patch for eslint-plugin-import-x to ensure compatibility with minimatch versions 9 and 10.

minimatch 10 drops support for node < 20 fixes un-ts#275

changeset-bot · 2025-03-31T12:01:57Z

🦋 Changeset detected

Latest commit: 22b095d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-import-x	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-03-31T12:02:03Z

Walkthrough

The change updates the minimatch dependency version in package.json. The version constraint is modified from "^10.0.1" to "^9.0.3 || ^10.0.1", which expands the accepted versions. This adjustment aims to restore compatibility with environments, such as those running Node 18, that may not work with only the later version.

Changes

File	Change Summary
package.json	Updated `minimatch` dependency version from "^10.0.1" to "^9.0.3
.changeset/tasty-lemons-sing.md	Added patch for `eslint-plugin-import-x` to ensure compatibility with `minimatch` versions 9 or 10.

Assessment against linked issues

Objective	Addressed	Explanation
Restore Node 18 compatibility (issue #275)	✅

Poem

I'm a rabbit, coding through the night,
Hopping over bugs with all my might.
Dependencies now set in a clever spin,
Allowing old Node to neatly jump in.
In code fields, I nibble on bits so bright!
🐇💻

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4af6a9 and 22b095d.

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (1)

.changeset/tasty-lemons-sing.md (1 hunks)

✅ Files skipped from review due to trivial changes (1)

.changeset/tasty-lemons-sing.md

⏰ Context from checks skipped due to timeout of 90000ms (19)

GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on ubuntu-latest
GitHub Check: Lint and Test with Node.js 18 and ESLint 9 on windows-latest
GitHub Check: Lint and Test with Node.js 18 and ESLint 8 on windows-latest
GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on windows-latest
GitHub Check: Lint and Test with Node.js 20 and ESLint 9 on windows-latest
GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on windows-latest
GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on windows-latest
GitHub Check: Lint and Test with Node.js 20 and ESLint 9 on ubuntu-latest
GitHub Check: Lint and Test with Node.js 18 and ESLint 8 on ubuntu-latest
GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on ubuntu-latest
GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on macos-latest
GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on ubuntu-latest
GitHub Check: Lint and Test with Node.js 18 and ESLint 9 on macos-latest
GitHub Check: Lint and Test with Node.js 20 and ESLint 9 on macos-latest
GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on macos-latest
GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on macos-latest

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

socket-security · 2025-03-31T12:02:25Z

Report too large to display inline

View full report↗︎

codesandbox-ci · 2025-03-31T13:42:52Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

pkg-pr-new · 2025-03-31T14:28:41Z

Open in Stackblitz

npm i https://pkg.pr.new/eslint-plugin-import-x@276

commit: 22b095d

codecov · 2025-03-31T14:33:24Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (6cba8eb) to head (22b095d).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files          91       91           
  Lines        4745     4745           
  Branches     1763     1787   +24     
=======================================
  Hits         4555     4555           
  Misses        189      189           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fix: allow minimatch 9 or 10

e4af6a9

minimatch 10 drops support for node < 20 fixes un-ts#275

JounQin approved these changes Mar 31, 2025

View reviewed changes

fix: update yarn.lock as well

0df89ea

Create tasty-lemons-sing.md

22b095d

JounQin merged commit e52168e into un-ts:master Mar 31, 2025
39 checks passed

github-actions bot mentioned this pull request Mar 30, 2025

chore: release eslint-plugin-import-x #273

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: allow minimatch 9 or 10 #276

fix: allow minimatch 9 or 10 #276

jribbens commented Mar 31, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Mar 31, 2025 •

edited

Loading

coderabbitai bot commented Mar 31, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

socket-security bot commented Mar 31, 2025 •

edited

Loading

codesandbox-ci bot commented Mar 31, 2025 •

edited

Loading

pkg-pr-new bot commented Mar 31, 2025 •

edited

Loading

codecov bot commented Mar 31, 2025 •

edited

Loading

fix: allow minimatch 9 or 10 #276

fix: allow minimatch 9 or 10 #276

Conversation

jribbens commented Mar 31, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

changeset-bot bot commented Mar 31, 2025 • edited Loading

🦋 Changeset detected

coderabbitai bot commented Mar 31, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

socket-security bot commented Mar 31, 2025 • edited Loading

codesandbox-ci bot commented Mar 31, 2025 • edited Loading

pkg-pr-new bot commented Mar 31, 2025 • edited Loading

codecov bot commented Mar 31, 2025 • edited Loading

Codecov Report

jribbens commented Mar 31, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Mar 31, 2025 •

edited

Loading

coderabbitai bot commented Mar 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

socket-security bot commented Mar 31, 2025 •

edited

Loading

codesandbox-ci bot commented Mar 31, 2025 •

edited

Loading

pkg-pr-new bot commented Mar 31, 2025 •

edited

Loading

codecov bot commented Mar 31, 2025 •

edited

Loading