feat(pack): support config.define #1956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fireairforce
commented
Jun 15, 2025
fireairforce
force-pushed
the
fix-napi-build
branch
from
11c48ae to
cd5f005
Compare
fireairforce
changed the title
xusd320
requested changes
Jun 16, 2025
crates/pack-cli/src/main.rs
Outdated
| .iter() | ||
| .map(|(key, value)| { | ||
| let value_str = match value { | ||
| Value::String(s) => format!("\"{}\"", s), |
There was a problem hiding this comment.
用 serde_json::stringify, 如果 value 本身是个 "xxx"， 外面直接套一层 "" 会挂掉
xusd320
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info refer to: #1953
这个 MR 修复两个问题:
config.defineconfig.define产物参考:
同时在 NAPI 包的 TS 层以及 Rust CLI 层做了修复，后续要考虑给配置添加
e2e产物 snapshot 测试了