fix: doctor parser error #808
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeachScript
reviewed
Apr 22, 2025
src/doctor/parser.ts
Outdated
| @@ -30,6 +30,7 @@ export default async ( | |||
| write: false, | |||
| // enable bundle for trigger onResolve hook, but all deps will be externalized | |||
| bundle: true, | |||
| loader: { '.js': 'jsx' }, | |||
There was a problem hiding this comment.
我其实是倾向于优化报错而不是加 loader 的，毕竟 JSX 并非 JS 就应该写在 .jsx 或者 .tsx 里，显式告诉构建工具这个文件的 AST 应该用什么来解析。
但社区构建工具宽容度还是太高了，就连 React 官方文档都是 App.js 而不是 App.jsx：https://react.dev/learn/writing-markup-with-jsx ，CRA 模板的构建配置也是一锅端的 babel 配置：https://github.com/facebook/create-react-app/blob/6254386531d263688ccfa542d0e628fbc0de0b28/packages/react-scripts/config/webpack.config.js#L417
所以我们有两个选择，顺应 or 坚持， @hualigushi @Jinbao1001 两位一起看看
There was a problem hiding this comment.
用户的项目是迁移过来的，如果这样的文件很多，是提示用户一个个改吗 ？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
复现仓库：https://github.com/hualigushi/react-js
问题描述：当一个文件后缀名是 js , 文件内容包含 jsx 语法时，doctor 命令会报错，但是 dev 和 build 命令均没有报错