Skip to content

Tokio ring crossbeam bump #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 28, 2025
Merged

Tokio ring crossbeam bump #307

merged 6 commits into from
Apr 28, 2025

Conversation

brainstorm
Copy link
Member

No description provided.

@brainstorm brainstorm requested a review from mmalenic April 28, 2025 03:53
@brainstorm
ci(fix): sccache deprecation notices break the build
0652d26
@brainstorm
build(fix): Apply iterator optimization according to clippy: 'error: …
c25a835 
…called Iterator::last on a DoubleEndedIterator; this will needlessly iterate the entire iterator'
mmalenic
mmalenic approved these changes Apr 28, 2025
View reviewed changes
@brainstorm
bump(deps): Noodles 0.97
f915ede
@brainstorm
build(deps): Back pedal on bincode version bump 1->2 due to ::seriali…
fc93a31 
…ze conflicts with crypt4gh... that method is contested on the crypt4gh-rust crate implementation anyway, so we might not even use that serialization approach in the (near?) future anyway.
@brainstorm
Copy link
Member Author

Alright, I will not update those three for now since actix-http (http's transitive dep) doesn't seem to bump to 1.3.1 anytime soon and we might not use bincode after all (as I mentioned in the last commit):

% cargo build --release
    Updating crates.io index
    Updating git repository `https://github.com/EGA-archive/crypt4gh-rust`
     Locking 544 packages to latest compatible versions
      Adding bincode v1.3.3 (available: v2.0.1)
      Adding http v0.2.12 (available: v1.3.1)
      Adding matchit v0.8.4 (available: v0.8.6)
      (...)

@mmalenic Would you mind double-checking my noodles changes though? Tests pass but perhaps that's not the best way to work with that index?

I'll merge now but happy to revert if that one's too off.

@brainstorm brainstorm added this pull request to the merge queue Apr 28, 2025
Merged via the queue into main with commit 396e5ff Apr 28, 2025
3 checks passed
@brainstorm brainstorm deleted the tokio_ring_crossbeam_bump branch April 28, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalenic mmalenic mmalenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brainstorm @mmalenic