Skip to content

hotfix: correct dark theme color for variant selector #19406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/16.0
Choose a base branch
from

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented May 23, 2025

fix the variant selector so hover uses themes colors (previously it was white in white, so not readable)

image

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This hotfix updates the variant selector’s hover state to use the correct theme color tokens.

  • Replaces --uui-palette-* variables with --uui-color-* tokens for surface and interactive emphasis.
  • Ensures hover styling aligns with both light and dark theme designs.
Comments suppressed due to low confidence (1)

src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts:598

  • Consider adding a matching :focus-visible style alongside :hover to ensure keyboard users receive equivalent visual feedback.
.switch-button:hover {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant