Skip to content

Allow actual text search on regions and country #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AkashRajpurohit opened this issue Apr 11, 2024 · 1 comment
Closed

Allow actual text search on regions and country #2665

AkashRajpurohit opened this issue Apr 11, 2024 · 1 comment
Labels
bug Something isn't working fixed in dev Fixed in the dev branch

Comments

@AkashRajpurohit
Copy link
Contributor

AkashRajpurohit commented Apr 11, 2024

Describe the Bug

Not sure if this should be logged as bug or feature, however the issue right now is that on the UI we show the country and region as the full string value i.e IN is shown as India and IN-DL as Delhi, India.

Now for a user when they see the string as Delhi, India, the general sense would be that searching for Del would give Delhi, India as response but that is not the case because currently the search is done on the shortcode and not the full text.

Attaching a screencast:

Screen.Recording.2024-04-11.at.11.05.09.AM.mov

Database

PostgreSQL

Relevant log output

No response

Which Umami version are you using? (if relevant)

2.11.1

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

Docker

@franciscao633 franciscao633 added the bug Something isn't working label Apr 11, 2024
@franciscao633
Copy link
Collaborator

You summarized the issue perfectly. We've been aware of the issue, and have a current task to fix this. Trying to get it out next release, but we are open to PRs as well.

mikecao added a commit that referenced this issue Nov 29, 2024
@mikecao mikecao added the fixed in dev Fixed in the dev branch label Dec 13, 2024
@mikecao mikecao closed this as completed Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in dev Fixed in the dev branch
Projects
None yet
Development

No branches or pull requests

3 participants