Fix running unit tests locally #68
Open
+29
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2025 12:02
jameshod5
reviewed
Apr 9, 2025
There was a problem hiding this comment.
This is the fix I was using, but in the docs: https://docs.xarray.dev/en/stable/generated/xarray.Dataset.to_zarr.html
It states that zarr_version is being depreciated? I'm not sure if this is a wider zarr bug
There was a problem hiding this comment.
Swapped back to zarr_version for now.
|
Raised issue with xarray: link |
|
All fixed now I think... |
Happy for this to be merged if everyone else is. |
jameshod5
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be some issue with running the unit tests with the zarr version.
This fixes that issue, and as a bonus enables
pyudatests when the user is connected to the UKAEA VPN.To test:
uv run pytest