Skip to content

Use the default message if the HTTP response message is null #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025
Merged

Use the default message if the HTTP response message is null #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ inputs:
required: false
runs:
using: 'docker'
image: 'docker://uhafner/quality-monitor:2.6.0-SNAPSHOT'
image: 'docker://uhafner/quality-monitor:2.5.3'
env:
CONFIG: ${{ inputs.config }}
CHECKS_NAME: ${{ inputs.checks-name }}
Expand Down
2 changes: 1 addition & 1 deletion doc/dependency-graph.puml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ rectangle "commons-math3\n\n3.6.1" as org_apache_commons_commons_math3_jar
rectangle "jackson-databind\n\n2.18.3" as com_fasterxml_jackson_core_jackson_databind_jar
rectangle "jackson-annotations\n\n2.18.3" as com_fasterxml_jackson_core_jackson_annotations_jar
rectangle "jackson-core\n\n2.18.3" as com_fasterxml_jackson_core_jackson_core_jar
rectangle "quality-monitor\n\n2.6.0-SNAPSHOT" as edu_hm_hafner_quality_monitor_jar
rectangle "quality-monitor\n\n2.5.3" as edu_hm_hafner_quality_monitor_jar
rectangle "github-api\n\n1.327" as org_kohsuke_github_api_jar
rectangle "codingstyle\n\n5.9.0" as edu_hm_hafner_codingstyle_jar
rectangle "spotbugs-annotations\n\n4.9.3" as com_github_spotbugs_spotbugs_annotations_jar
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<groupId>edu.hm.hafner</groupId>
<artifactId>quality-monitor</artifactId>
<version>2.6.0-SNAPSHOT</version>
<version>2.5.3</version>
<packaging>jar</packaging>

<scm>
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/edu/hm/hafner/grading/github/QualityMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ private void addComment(final AggregatedScore score, final String textSummary,

var prNumber = getEnv("PR_NUMBER", log);
if (!prNumber.isBlank()) { // optional PR comment
var footer = "Created by %s.%s".formatted(getVersionLink(log), checksResult);
var footer = "Created by %s. %s".formatted(getVersionLink(log), checksResult);
github.getRepository(repository)
.getPullRequest(Integer.parseInt(prNumber))
.comment(prSummary + "\n\n" + footer + "\n");
Expand Down Expand Up @@ -177,7 +177,7 @@ private String createChecksRun(final FilteredLog log, final GHCheckRunBuilder ch
private void logException(final FilteredLog log, final IOException exception, final String message) {
String errorMessage;
if (exception instanceof HttpException responseException) {
errorMessage = responseException.getResponseMessage();
errorMessage = StringUtils.defaultIfBlank(responseException.getResponseMessage(), exception.getMessage());
}
else {
errorMessage = exception.getMessage();
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/edu/hm/hafner/grading/github/QualityMonitorDockerITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ void shouldShowErrors() throws TimeoutException {
}

private GenericContainer<?> createContainer() {
return new GenericContainer<>(DockerImageName.parse("uhafner/quality-monitor:2.6.0-SNAPSHOT"));
return new GenericContainer<>(DockerImageName.parse("uhafner/quality-monitor:2.5.3"));
}

private String readStandardOut(final GenericContainer<? extends GenericContainer<?>> container)
Expand Down
Loading