Bump error-prone.version from 2.36.0 to 2.37.0

[dependabot]

Bumps error-prone.version from 2.36.0 to 2.37.0.
Updates com.google.errorprone:error_prone_annotations from 2.36.0 to 2.37.0

Release notes

Sourced from com.google.errorprone:error_prone_annotations's releases.

Error Prone 2.37.0

Changes:

• The annotations that were previously in error_prone_type_annotations have been been merged into error_prone_annotations. error_prone_type_annotations is now deprecated, and will be removed in a future release.

New checks:

• AssignmentExpression - The use of an assignment expression can be surprising and hard to read; consider factoring out the assignment to a separate statement.
• IntFloatConversion - Detect calls to scalb that should be using the double overload instead
• InvalidSnippet - Detects snippets which omit the : required for inline code.
• JUnit4EmptyMethods - Detects empty JUnit4 @Before, @After, @BeforeClass, and @AfterClass methods.
• MockIllegalThrows - Detects cases where Mockito is configured to throw checked exception types which are impossible.
• NegativeBoolean - Prefer positive boolean names.
• RuleNotRun - Detects TestRules not annotated with @Rule, that won't be run.
• StringConcatToTextBlock - Replaces concatenated multiline strings with text blocks.
• TimeInStaticInitializer - Detects accesses of the system time in static contexts.

Closed issues:

• Propagate check flags in patch mode (#4699)
• Fixes a crash in ComputeIfAbsentAmbiguousReference (#4736)
• Show the field name in HidingField diagnostics (#4775)
• Add support for jakarta annotations to some checks (#4782)
• FloatingPointAssertionWithinEpsilonTest depends on default locale (#4815)
• @InlineMe patching of Strings.repeat produces broken code (#4819)
• Fix a crash in IdentifierName on unnamed (_) variables (#4847)
• Fix a crash in ArgumentParameterSwap (#490)

Full changelog: google/error-prone@v2.36.0...v2.37.0

Commits

• a453935 Release Error Prone 2.37.0
• 81faa5a Update JDK versions in release.yml
• 62086b7 Handle multiple arguments in thenThrow.
• 7440ff1 In StringConcatToTextBlock, don't assume that string literals always have sou...
• 04fe835 Adds type_annotations back but as a relocation to annotations
• 1ad73c2 Handle yield in Reachability
• b1b521f Sniff out the canonical constructor using detective work rather than a flag w...
• 86e5c95 Optimization: Abort class scan in JUnit4TestNotRun if all suspicious method...
• c139e7f [StatementSwitchToExpressionSwitch] for the return switch pattern, fix a bug ...
• 296fb4e Hardcode BoxedPrimitiveEquality:ExemptStaticConstants = false.
• Additional commits viewable in compare view

Updates com.google.errorprone:error_prone_core from 2.36.0 to 2.37.0

Release notes

Sourced from com.google.errorprone:error_prone_core's releases.

Error Prone 2.37.0

Changes:

• The annotations that were previously in error_prone_type_annotations have been been merged into error_prone_annotations. error_prone_type_annotations is now deprecated, and will be removed in a future release.

New checks:

• AssignmentExpression - The use of an assignment expression can be surprising and hard to read; consider factoring out the assignment to a separate statement.
• IntFloatConversion - Detect calls to scalb that should be using the double overload instead
• InvalidSnippet - Detects snippets which omit the : required for inline code.
• JUnit4EmptyMethods - Detects empty JUnit4 @Before, @After, @BeforeClass, and @AfterClass methods.
• MockIllegalThrows - Detects cases where Mockito is configured to throw checked exception types which are impossible.
• NegativeBoolean - Prefer positive boolean names.
• RuleNotRun - Detects TestRules not annotated with @Rule, that won't be run.
• StringConcatToTextBlock - Replaces concatenated multiline strings with text blocks.
• TimeInStaticInitializer - Detects accesses of the system time in static contexts.

Closed issues:

• Propagate check flags in patch mode (#4699)
• Fixes a crash in ComputeIfAbsentAmbiguousReference (#4736)
• Show the field name in HidingField diagnostics (#4775)
• Add support for jakarta annotations to some checks (#4782)
• FloatingPointAssertionWithinEpsilonTest depends on default locale (#4815)
• @InlineMe patching of Strings.repeat produces broken code (#4819)
• Fix a crash in IdentifierName on unnamed (_) variables (#4847)
• Fix a crash in ArgumentParameterSwap (#490)

Full changelog: google/error-prone@v2.36.0...v2.37.0

Commits

• a453935 Release Error Prone 2.37.0
• 81faa5a Update JDK versions in release.yml
• 62086b7 Handle multiple arguments in thenThrow.
• 7440ff1 In StringConcatToTextBlock, don't assume that string literals always have sou...
• 04fe835 Adds type_annotations back but as a relocation to annotations
• 1ad73c2 Handle yield in Reachability
• b1b521f Sniff out the canonical constructor using detective work rather than a flag w...
• 86e5c95 Optimization: Abort class scan in JUnit4TestNotRun if all suspicious method...
• c139e7f [StatementSwitchToExpressionSwitch] for the return switch pattern, fix a bug ...
• 296fb4e Hardcode BoxedPrimitiveEquality:ExemptStaticConstants = false.
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[github-actions]

☀️   Quality Monitor

Tests

     JUnit Tests: 98% successful (103 passed, 2 skipped)

Code Coverage

   〰️   Line Coverage: 92% (61 missed lines)
   ➰   Branch Coverage: 91% (19 missed branches)

Mutation Coverage

     Mutation Coverage: 80% (80 survived mutations)
   💪   Test Strength: 85% (58 survived mutations in tested code)

Style

     CheckStyle: No warnings
     PMD: No warnings

Bugs

     SpotBugs: No bugs
   🐛   Error Prone: No bugs

API Problems

   🚫   Revapi: No warnings

Vulnerabilities

     OWASP Dependency Check: No vulnerabilities

Software Metrics

   🌀   Cyclomatic Complexity: 376 (total)
   💭   Cognitive Complexity: 173 (total)
   ➿   N-Path Complexity: 455 (total)
   📏   Lines of Code: 4270 (total)
   📝   Non Commenting Source Statements: 1257 (total)
   🔗   Class Cohesion: 71.43% (maximum)
   ⚖️   Weight of Class: 100.00% (maximum)

---

Created by Quality Monitor v2.4.0 (#1e6c188). More details are shown in the GitHub Checks Result.