fix: respect workspace in collection & integration type after save bots #4830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techfg
changed the title
humandad
reviewed
Apr 17, 2025
| @@ -29,7 +29,7 @@ HTTP 200 | |||
| # TODO: Unclear why this assert exists as its fragile and likely does not help in any way since underlying | |||
| # data can change across the test suite. Evaluate this tests purpose and adjust the assert to be | |||
| # explicit/more meaningful or remove. | |||
| jsonpath "$[*]" count == 29 | |||
| jsonpath "$[*]" count == 30 | |||
There was a problem hiding this comment.
Wait... Were these asserts actually relying on the bug you just fixed to delete a collection? Not that it's fixed, the collection isn't deleted?
There was a problem hiding this comment.
These are asserting against dev workspace. I changed the test here to delete the "duplicate" workspace I created instead of deleting from dev workspace so these counts went up.
humandad
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures that workspace is respected when collection & integration type metadata is being deleted after a collection/integration type has been removed.
Resolves #4801
Testing
tested manually and confirmed.
TBD: Write tests.