fix: e2e failing on macOS #4778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (3)
- apps/platform-e2e/package.json: Language not supported
- apps/platform-e2e/tsconfig.json: Language not supported
- nx.json: Language not supported
Comments suppressed due to low confidence (1)
apps/platform-e2e/README.md:40
- The documentation appears to have conflicting instructions regarding the configuration format (switching between ts and mjs). Please clarify which configuration should be used to avoid confusion.
When `package.json` exists in `platform-e2e` folder with "type": "module", `npx nx graph` no longer seems to fail so changing approach to go back to `ts` file and adding `package.json` to folder with "type": "module". This is still a workaround for what appears to be an issue with cypress and/or nx/cypress integration where it respects root level package.json "type": "module" to get things started but then NX cypress plugin only looks in the folder itself and ends up loading commonjs. Nothing wrong with having the package.json in the folder with "type": "module", just should be unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
e2e tests are failing on macOS, but work on linux including CI.
This should make them work everywhere. See README in platform-e2e folder for details.
Testing
Works on linux. ci & e2e will cover.
@humandad - Please test on mac and let me know. Thanks!