failed wire loads should not cause the entire view to fail in loading #4576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-view-to-fail-in-loading
abeljimo
changed the title
…e-view-to-fail-in-loading
…e-view-to-fail-in-loading
…e-view-to-fail-in-loading
…e-view-to-fail-in-loading
humandad
deleted the
failed-wire-loads-should-not-cause-the-entire-view-to-fail-in-loading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
aims to solve this issue #4359 instead of breaking the page and showing an error message the error is now displayed as a property on the wire itself. The other wires will load normally.
Testing
If relevant, explain how to test the change locally