-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix: don't consider text nodes with blank lines as completely empty #6437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: bf01f37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Changes Overview
Closes #6436
Implementation Approach
Testing Done
Verification Steps
This work well with code blocks. Create an editor with a codeblock and type in some text that contains a blank line, e.g.
and call
isNodeEmpty()
on it. It incorrectly returnstrue
, with this PR it returnsfalse
.Additional Notes
Checklist
Related Issues