Skip to content

Fix callVariant with fusion in the same transcript #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 17, 2022

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Jan 16, 2022

As described in #342 that Arriba calls fusion in the same gene, which causes a problem of the graph data structure because we currently use transcript/gene ID as the subgraph ID to differentiate between the main graph and subgraph being inserted or fused. So in the PR, I redesigned data structure of how the relationship between subgraphs are handled. I use a tree-like structure (SubgraphTree), which is just simply a dict, that the keys are the subgraph ID, and the values are SubgraphLocation which has attributes of level, parent_id, and the location at the parent graph. I also switched to use a UUID for any subgraph ID just to avoid any collision.

Closes #341
Closes #342
Closes #343

@zhuchcn zhuchcn requested a review from lydiayliu January 16, 2022 23:46
@zhuchcn
Copy link
Member Author

zhuchcn commented Jan 17, 2022

#347 is actually the same issue. In CVG, the variant graph is extended for another loop so it covers the variant peptides that span over the junction site. And previously the same transcript ID is used as subgraph_id, so it causes trouble when it tries to compare the relative position of two nodes over the junction site. It is now also updated to use the new SubgraphTree and use a unique subgraph_id to avoid this problem.

@zhuchcn zhuchcn linked an issue Jan 17, 2022 that may be closed by this pull request
@lydiayliu
Copy link
Contributor

ok i can confirm all the fusion cases were resolved. will merge now to play with the cpus setting and test the circ case

@lydiayliu lydiayliu merged commit efdd675 into main Jan 17, 2022
@lydiayliu lydiayliu deleted the czhu-fix-call-variant-fusion branch January 17, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants