Add i18n support #203
Merged
Add i18n support #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a translation from Joel Barrios from back in 2017, with slight adjustments for newer strings where only newlines were stripped or so. It is not 100% complete as per the current dock version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a separate take from the older and manually implemented #116, which uses existing build system in a conventional manner.
The included French translation has been made by a colleague for the occasion. The Spanish one has been extracted from #116 with slight adaptation where the C strings changed only cosmetically, but there are some untranslated strings now (it's at 83%, though 3 strings don't matter, so it's more like 85).
Apart from that it's fairly straightforward: it makes the necessary Autoconf/Automake changes to use gettext through the usual means, and marks strings as translatable. One more subtle bit is that it alters the code to fetch the localized version of the application name from the desktop files, so that it's also properly localized.