Skip to content

Program activation by dragging doesn't work #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabdub opened this issue Apr 25, 2018 · 4 comments
Closed

Program activation by dragging doesn't work #132

gabdub opened this issue Apr 25, 2018 · 4 comments

Comments

@gabdub
Copy link

gabdub commented Apr 25, 2018

The dock does not activate another running program when dragging a file from caja over the program icon.

I'm running version v0.85 (GTK3) from Ubuntu Mate 18.04 Beta 2 + updates.

I added some calls to log_it() and found that in the function applet_drag_motion (dock_applet.py line 512) the test if app is None: is always false. It seems that app is not set to None when the drag begins.

@gabdub
Copy link
Author

gabdub commented Apr 27, 2018

Now running Ubuntu Mate 18.04 (not beta).

dock-p-crash
If I remove the test, the drag works again.

@nschulzke
Copy link

I think it's actually missing a definition for app:

    app = the_dock.get_dragee()

This is in the applet_drag_end function, and adding this line just before the check solves the problem for me.

@gabdub
Copy link
Author

gabdub commented Apr 28, 2018

Yes, I think you are right.

@robint99
Copy link
Contributor

Thanks to you both for looking into this. It seems that I accidentally deleted that line of code back in February ... I've put it back and committed the change, so I'll close this issue now.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants