GeoPoint -> LatLng #466
Merged
GeoPoint -> LatLng #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date" This reverts commit 25cb2c3.
|
@isaacbrodsky, I'm not sure why the website was breaking and this fixed it, as I'm not really sure what would have changed to break things... Also, I updated the |
ajfriend
commented
May 30, 2021
nrabinowitz
approved these changes
Jun 1, 2021
| /** @brief icosahedron face centers in lat/lon radians */ | ||
| const GeoPoint faceCenterGeo[NUM_ICOSA_FACES] = { | ||
| /** @brief icosahedron face centers in lat/lng radians */ | ||
| const LatLng faceCenterGeo[NUM_ICOSA_FACES] = { |
There was a problem hiding this comment.
This one's super helpful, since we declare the data below positionally
| List<Long> polyfill(List<GeoCoord> points, List<List<GeoCoord>> holes, int res); | ||
| List<String> polyfillAddress(List<GeoCoord> points, List<List<GeoCoord>> holes, int res); | ||
| List<Long> polyfill(List<LatLng> points, List<List<LatLng>> holes, int res); | ||
| List<String> polyfillAddress(List<LatLng> points, List<List<LatLng>> holes, int res); |
There was a problem hiding this comment.
These Java ones are anticipating that the binding will change, not sure if that makes sense at this point?
There was a problem hiding this comment.
We should use consistent terms in the bindings as well, so this makes sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep the number of changes under control, I've tried to focus this PR around the renaming of
GeoPointtoLatLngand generally usinglnginstead oflonthroughout the codebase. I list a few other potential related changes that we might also want to consider, but I'm proposing we do those in a separate PR.Renaming
GeoPointtoLatLngLinkedGeoPointtoLinkedLatLng(is this one a bit weird?)pointToCelltolatLngToCellcellToPointtocellToLatLngvertexToPointtovertexToLatLnglnginstead oflonthroughout the codebaseWork for follow-up PRs
LinkedGeoPolygon?LinkedGeoLoop?GeoLoop?GeoPolygon?GeoMultiPolygon?pointDist*tosphereDist*?