Skip to content

Optimization to annotation stripping in library model matching #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

msridhar
Copy link
Collaborator

Small optimization over #1203; pre-compile the Pattern used for matching.

@msridhar msridhar marked this pull request as draft April 24, 2025 17:48
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.21%. Comparing base (d40de5e) to head (ed61f3c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1204   +/-   ##
=========================================
  Coverage     88.21%   88.21%           
  Complexity     2317     2317           
=========================================
  Files            88       88           
  Lines          7577     7578    +1     
  Branches       1513     1513           
=========================================
+ Hits           6684     6685    +1     
  Misses          448      448           
  Partials        445      445           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Main Branch:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.943 ± 0.113  ops/s
CaffeineBenchmark.compile         thrpt   25   3.745 ± 0.017  ops/s
DFlowMicroBenchmark.compile       thrpt   25  27.947 ± 0.264  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.441 ± 0.021  ops/s

With This PR:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25  10.149 ± 0.045  ops/s
CaffeineBenchmark.compile         thrpt   25   3.721 ± 0.025  ops/s
DFlowMicroBenchmark.compile       thrpt   25  28.133 ± 0.340  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.447 ± 0.022  ops/s

@msridhar msridhar marked this pull request as ready for review April 24, 2025 19:34
@msridhar msridhar enabled auto-merge (squash) April 24, 2025 19:34
@msridhar msridhar merged commit 4a9a9ef into master Apr 28, 2025
13 checks passed
@msridhar msridhar deleted the small-optimization branch April 28, 2025 19:49
dhruv-agr pushed a commit to dhruv-agr/NullAway that referenced this pull request May 9, 2025
…1204)

Small optimization over uber#1203; pre-compile the `Pattern` used for
matching.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants