Skip to content

Modernize repo #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 23, 2023
Merged

Modernize repo #471

merged 26 commits into from
Jul 23, 2023

Conversation

ZacSweers
Copy link
Collaborator

@ZacSweers ZacSweers commented Jul 22, 2023

This is a couple years' worth of upgrades but reviewing by commit should be ok! Most of the line diff is due to a formatter change.

  • Gradle 8.2.1
  • Migrate to Gradle version catalogs
    • Makes it easier to set up automated dependency management in the future, such as Renovate or Dependabot
  • Upgrade dependencies. Relevant public-facing ones below
    • AndroidX Lifecycle 2.6.1
    • Kotlin 1.9.0
    • RxJava 3.1.6
    • RxAndroid 3.0.2
  • Update lint to 8.0.0, also updates its jvm target to 17 (required)
  • Update build to use jdk 17 (still targeting jvm target 8 for anywhere not lint)
  • Clean up a bunch of boilerplate in the root build file now that we get better types with kotlin dsl
  • Switch to KSP for autoservice handling
  • AGP 8.0
  • Update to ktfmt for formatting. Ktlint is hardly maintained and doesn't have consistent formatting
  • Fix lint not capturing changed argument orders in withScope use
  • Migrate to kotlin gradle DSL
  • Finally run error prone on the sample
  • Update error prone and fix any new issues
  • Upgrade publishing to latest APIs + auto-closing/releasing
  • Modernize Dokka rendering, prettify docs, modernize website publishing structure

@ZacSweers ZacSweers marked this pull request as ready for review July 22, 2023 23:34
@ZacSweers ZacSweers requested a review from jbarr21 July 22, 2023 23:34
@ZacSweers ZacSweers merged commit 0318d87 into main Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants