Skip to content

daemon: get docker-compose release dynamically #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 3, 2020

Conversation

bobheadxi
Copy link
Member

🎟️ Ticket(s): Closes #665


👷 Changes

  • daemon(containers): exclude prerelease images
  • daemon(all): get docker/compose dynamically or use latest

@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Apr 3, 2020
@bobheadxi bobheadxi requested a review from a team April 3, 2020 04:05
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #667 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage   51.56%   51.59%   +0.03%     
==========================================
  Files          75       75              
  Lines        3848     3856       +8     
==========================================
+ Hits         1984     1989       +5     
- Misses       1615     1618       +3     
  Partials      249      249              
Impacted Files Coverage Δ
daemon/inertiad/build/builder.go 74.20% <ø> (ø)
daemon/inertiad/cfg/config.go 100.00% <100.00%> (ø)
daemon/inertiad/containers/images.go 75.00% <100.00%> (ø)
cfg/util.go 64.52% <0.00%> (-5.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b2f5a...8bd05af. Read the comment docs.

@bobheadxi bobheadxi merged commit ddc6f9f into master Apr 3, 2020
@bobheadxi bobheadxi deleted the daemon/dynamic-docker-compose-version branch April 3, 2020 05:43
@bobheadxi bobheadxi mentioned this pull request Apr 3, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: finalized needs review and final approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

daemon: search and pull docker/compose image instead of hardcoding version
1 participant