initNews NPE fix

[Naenyn]

Adds some null checking and modifies the handling of newly created newsSets.

[Copilot]

Pull Request Overview

This PR fixes potential null pointer exceptions by adding null checks and refining the handling of news set creation and retrieval. Key changes include:

• Added null checks for PortletRequest and userId in SharedNewsSetServiceImpl.
• Enhanced error handling when persisting and retrieving NewsSet objects.
• Added additional null checks for the roles and NewsSet parameters in HibernateNewsStore.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/main/java/org/jasig/portlet/newsreader/service/SharedNewsSetServiceImpl.java	Added null checks and updated error handling during NewsSet creation and retrieval.
src/main/java/org/jasig/portlet/newsreader/mvc/portlet/reader/AjaxNewsController.java	Added null check for NewsSet and updated flow to return a friendly error message.
src/main/java/org/jasig/portlet/newsreader/dao/HibernateNewsStore.java	Introduced null checks for NewsSet and roles in initNews and storeNewsSet methods.

Comments suppressed due to low confidence (1)

src/main/java/org/jasig/portlet/newsreader/service/SharedNewsSetServiceImpl.java:122

• [nitpick] Consider revising 're-initalising' to 'reinitializing' for improved readability and consistency.

logger.debug("re-initalising loaded newsSet " + set.getName());

[Copilot]

Consider logging the full exception (e.g., by passing 'e' as a parameter) to aid debugging rather than just logging the exception message.

Suggested change

	logger.error("Error creating NewsSet for userId={}, fname={}: {}", userId, fname, e.getMessage());
	logger.error("Error creating NewsSet for userId={}, fname={}", userId, fname, e);

[bjagg]

🏅