Skip to content

fix: add test and new dep for missing xalan serializer #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

bjagg
Copy link
Member

@bjagg bjagg commented Jun 6, 2025

No description provided.

@bjagg bjagg requested review from Naenyn and Copilot June 6, 2025 16:21
@bjagg bjagg self-assigned this Jun 6, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures the Xalan serializer is on the classpath by adding its Maven dependency and verifies it via a new unit test.

  • Introduce xalan.version property and manage xalan/serializer versions centrally.
  • Add serializer dependency alongside xalan in both dependencyManagement and runtime dependencies.
  • Create XalanSerializerTest to assert that OutputPropertiesFactory loads default XML properties.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/test/java/org/jasig/portlet/newsreader/XalanSerializerTest.java New JUnit test to verify Xalan’s OutputPropertiesFactory loads.
pom.xml Defines xalan.version and adds xalan:serializer to dependencies.
Comments suppressed due to low confidence (2)

src/test/java/org/jasig/portlet/newsreader/XalanSerializerTest.java:32

  • The test only checks that props is not null; consider adding assertions for specific expected keys or values (e.g., indent settings) to ensure the serializer behavior is correct.
Properties props = OutputPropertiesFactory.getDefaultMethodProperties("xml");

src/test/java/org/jasig/portlet/newsreader/XalanSerializerTest.java:28

  • [nitpick] The class is named XalanSerializerTest but the test targets OutputPropertiesFactory; consider renaming to OutputPropertiesFactoryTest or broadening the test to explicitly cover serialization behavior.
public class XalanSerializerTest {

Copy link
Contributor

@Naenyn Naenyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Naenyn Naenyn merged commit 205abad into uPortal-Project:master Jun 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants