Dark Mode support

[BenSokol]

Prerequisites

• I verified that this is not a filter issue
  • Filter issues MUST be reported at filter issue tracker
• This is not a support issue or a question
  • Support issues and questions are handled at /r/uBlockOrigin
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
• I tried to reproduce the issue when...
  • uBlock Origin is the only extension
  • uBlock Origin with default lists/settings
  • using a new, unmodified browser profile
• I am running the latest version of uBlock Origin
• I checked the documentation to understand that the issue I report is not a normal behavior

Description

macOS 10.14 introduced "dark mode", which swaps the system color palette to a dark scheme. Chrome just added support for this in Google Chrome Canary. uBlock Origin doesn't currently support this. I realize this is Canary, however Dark Mode will be added to a future version of Google Chrome. It is presently on track to be in m73 (March 12, 2019) or m74 (April 23, 2019). NOTE: This is not a Canary "Bug" it is a new feature that will be added to chrome.

A specific URL where the issue occurs

Chromium Issue Tracker showing "Dark Mode" is now enabled by default in Chromium. As Google Chrome Canary is built off master nightly, this is present there. https://bugs.chromium.org/p/chromium/issues/detail?id=850098#c58
Release Schedule for Chromium/Chrome: https://www.chromium.org/developers/calendar

Steps to Reproduce

1. Open Google Chrome Canary (must be updated past Thursday, January 24, 2019's nightly build.
2. Open any of uBlock Origin's menus (i.e. click icon in menu bar, go to extension settings, etc.)

Expected behavior:

uBlock Origin's Menu pages are bright white with black text. They should (in theory) follow Google Chrome Canary's default color scheme, which has now been expanded.

Actual behavior:

Google Chrome Canary appears in dark mode, however uBlock Origin menus are all bright white with black text (same as normal mode)

Your environment

• uBlock Origin version: 1.18.1rc0
• Browser Name and version: Google Chrome Canary (Version 73.0.3683.3 (Official Build) canary (64-bit))
• Operating System and version: macOS Mojave (Version 10.14.3)

[tophf]

Apparently uBO will be able to do it via the new CSS @media (prefers-color-scheme: dark) in Canary: https://crrev.com/c/1396404 is the first step, but the actual support is not yet implemented IIUC.

Update:
Looks like the actual support was just added in https://crrev.com/c/1520677

[androidacy-user]

Would this be similar achievable in Firefox? I know FF does not normal have dark mode (ok, ok, there are themes [or substratum on Android]) but an option for a dark color scheme in the extension would be awesome.

Sent from my TETRA using FastHub

[uBlock-user]

With 74.0.3716.0 on Windows 10, Chromium's dark mode is now activated if you have dark theme on OS.

[johnp]

Firefox recently received support (targeting 67) for prefers-color-scheme. There already is an unofficial dark theme available under the ShadowFox project that maybe could be used.

[dannycolin]

@johnp Firefox also has an official dark mode. Support for prefers-color-scheme of that dark mode is currently in Nightly (https://bugzilla.mozilla.org/show_bug.cgi?id=1519547). I guess opening an issue specific to FF would be a good idea.

[jeremyperkin]

Hi,

So I will have this completed before the end of the week. At least that is what I expect. Would like to get some feed back on colour scheme that I have used so far. Any chance someone would like to copy the popup.css code that I have put here and run with it for a bit. Please rename your copy of popup.css to popup.old and just paste the code here into your popup.css file. https://github.com/jeremyperkin/uBlockdark/blob/master/popup.css

NOTE : current var names are temp - can be tightened up later on. For now went long in order to be able to easily the change.

[jeremyperkin]

Dark Mode has been completed for chromium. Wondering if @gorhill you have time to connect? Here is the candidate for consideration v.01 https://github.com/jeremyperkin/uBlockdark

[gorhill]

Thanks, give me some time to look into this, this might be only in the next weekend though.

[jeremyperkin]

Thanks, give me some time to look into this, this might be only in the next weekend though.
@gorhill
Hi, Just wounder if you have had a chance to take a look?
This way I can make adjustments and implement your ideas or thoughts.

[jeremyperkin]

@gorhill almost been a month since I have heard back from you. Hope everything is ok. But I know you are probably super busy.

Here is a link to version I was working on - just variable names that I found were throughout the code. I am looking to do more but just waiting on the word from you. https://github.com/jeremyperkin/uBlockdark/tree/master/variables

Interested in also working on more projects as well.