Skip to content

Specific filter list has no rules loaded unless its URL is changed to be the same when parsed but different when in plaintext #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
9 tasks done
npxl32 opened this issue Dec 7, 2024 · 8 comments
Labels
invalid not a uBlock issue

Comments

@npxl32
Copy link

npxl32 commented Dec 7, 2024

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

This specific filterlist - a.k.a., this specific filter list (the problem
only happens with this one) - will not be loaded at all in uBO. it will get added as a custom filter list but 0 filters will be recognized. However, it WILL load if I change the URL to be the same when parsed but different in plaintext (e.g. Doing weird path name trickery tricks https://easylist-downloads.adblockplus.org/.%2E/exceptionrules.txt, including the port number https://easylist-downloads.adblockplus.org:443/exceptionrules.txt)

A specific URL where the issue occurs.

extension://odfafepnkmbhccpbejgmiehpchacaeak/dashboard.html#3p-filters.html

Steps to Reproduce

  1. Add this filter list into uBO
  2. Watch 0 out of 0 filters be recognized

Expected behavior

  1. Add this filter list
  2. Watch the full ~600k filters be recognized

Actual behavior

  1. Add this filter list
  2. 0 out of 0 filters were recognized

Workaround:

  1. Add the filter list, but do something to make the parsed URL same but plaintext URL different (e.g. including the 443 port number)
  2. It works

uBO version

1.61.2

Browser name and version

Microsoft Edge Dev 133.0.2992.0

Operating System and version

Microsoft Windows Version 23H2 (OS Build 22631.4541) © Microsoft Corporation. All rights reserved.

@npxl32 npxl32 changed the title Filter list has no rules loaded unless its URL is changed to be the same Filter list has no rules loaded unless its URL is changed to be the same when parsed but different when in plaintext Dec 7, 2024
@npxl32 npxl32 changed the title Filter list has no rules loaded unless its URL is changed to be the same when parsed but different when in plaintext Specific filter list has no rules loaded unless its URL is changed to be the same when parsed but different when in plaintext Dec 7, 2024
@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Dec 7, 2024

@npxl32
Copy link
Author

npxl32 commented Dec 7, 2024

Thanks for the clarification, this should really be in the wiki or something

@npxl32 npxl32 closed this as completed Dec 7, 2024
@uBlock-user uBlock-user closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2024
@uBlock-user uBlock-user added the invalid not a uBlock issue label Dec 7, 2024
@stephenhawk8054
Copy link
Member

From that list's description, it's for "Acceptable Ads" program and uBO does not support "Acceptable Ads" program

@npxl32
Copy link
Author

npxl32 commented Dec 7, 2024

        if ( this.badLists.get(url) === true ) { continue; }

This line of code in gorhill/uBlock/src/js/storage.js clearly isn't doing its job if I'm able to bypass it like this (see workaround)

In such a high quality program such as uBO, if only that snippet of code which is clearly an afterthought would actually parse the URL like so, that would be nice.

        if ( this.badLists.get(new URL(url).href) === true ) { continue; }

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Dec 7, 2024

Yes, we don't lock users to not use those lists completely. Any users who want to use those lists at all costs can find a way themselves. We'll just lock specific workaround-URLs if they appear on the reports from users' issues.

@uBlock-user
Copy link
Contributor

if I'm able to bypass it like this (see workaround)

You're being allowed to bypass as the intention is not to block all urls.

@freezer2022
Copy link

npxl32: or something

It is mentioned in several places. Duplicate of:


npxl32: "0 out of 0"

When searching for: "0 out of 0" it finds #1331: LINK.

npxl32: This specific filterlist

When searching for https://easylist-downloads.adblockplus.org/exceptionrules.txt it finds it in badlists: LINK.
Then when searching for badlists, it finds #2582: LINK

npxl32: this should really be in the wiki

The previous user asked the same: #1331 (comment).

Yes, it seems it should be in Wiki, because:

  • some users can't handle github search feature
    • and even for those who can handle it, it might be too much time consuming / impractical
  • for some other users it might be too complicated to understand all the technical details, becase they might be unfamiliar with uBO (especially new users)

Hence Wiki has been updated: https://github.com/uBlockOrigin/uBlock-issues/wiki/Dashboard:-Filter-lists#unsupported-filter-lists-bad-lists

@npxl32
Copy link
Author

npxl32 commented Dec 8, 2024

It is mentioned in several places. Duplicate of:

It didn't occur to me at the time of this issue that there may have been several "nonworking" filterlists beyond exceptionrules, so it didn't occur to me when searching for duplicates to keep that in mind, this is a bad on my part

I didn't look in discussions, this is also a bad on my part, however doing a very rudimentary search of the discussions right now does not give results

  • The concept of "bad list" has been introduced, to prevent users from unwittingly end up using what are deemed "bad lists" by the uBO team. Some "bad lists" will be completely ignored and importing them will be forbidden by uBO. This restriction can be bypassed by users by simply appending a dummy query parameter to the URL of the list.

Again, same problem 2 spots above, my bad

It wasn't obvious to search for "bad lists" for the same reason that it didn't occur to me that there may have been multiple "nulled-out" filterlists although that is probably a bad on my part

npxl32: "0 out of 0"

When searching for: "0 out of 0" it finds #1331: LINK.

Me being stupid

npxl32: This specific filterlist

When searching for https://easylist-downloads.adblockplus.org/exceptionrules.txt it finds it in badlists: LINK.

I searched in gorhill/uBlock because I thought that that one specific list was hardcoded to not work, again, this is probably a bad on my part

Also, I believe I did search for that in the issue tracker but it just didn't yield actual answers other than "uBO doesn't support Acceptable Ads", and I mainly opened this issue not because the filter list wouldn't work but was mainly about how I thought the fact that I could work around it was unintended behavior, I may not have made that clear enough, again a bad on my part

npxl32: this should really be in the wiki

That's usually where I go for an unseen behavior/problem and advice

Yes, it seems it should be in Wiki, because:

  • some users can't handle github search feature

    • and even for those who can handle it, it might be too much time consuming / impractical
      If you're implying I can't you're probably right
  • for some other users it might be too complicated to understand all the technical details, becase they might be unfamiliar with uBO (especially new users)

If you're implying that I'm a new user, I'm not, I'm decently familiar with how to use uBO, I've read through the entire wiki and I use dynamic filtering with uBO on hard mode
I'm just not familiar with uBO's backend

Hence Wiki has been updated: https://github.com/uBlockOrigin/uBlock-issues/wiki/Dashboard:-Filter-lists#unsupported-filter-lists-bad-lists

And in the wiki:

Related issues/discussions:

#1331
#2528 (comment)
#3476 (this issue)

This issue is hereby inducted into the hall of shame

@uBlockOrigin uBlockOrigin locked as resolved and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid not a uBlock issue
Projects
None yet
Development

No branches or pull requests

4 participants