Trusted-click-element cannot click shadow dom elements

[peace2000]

Prerequisites

• I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
• This is NOT an issue with YouTube, Facebook or Twitch.
• This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
• The issue is not present after disabling uBO in the browser.
• I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

• uBO is the only extension.
• uBO uses default lists and settings.
• using a new, unmodified browser profile.

Description

Trusted-click-element cannot click shadow dom elements.

A specific URL where the issue occurs.

https://racingnews365.com/watch-nascar-driver-ryan-preece-survives-daytona-barrel-roll-accident

Steps to Reproduce

1. Add filter racingnews365.com##+js(trusted-click-element, .cmpboxbtnyes)
2. Open https://racingnews365.com/watch-nascar-driver-ryan-preece-survives-daytona-barrel-roll-accident

Expected behavior

The button would be clicked.

Actual behavior

It can't be clicked.

uBO version

1.53.5rc11

Browser name and version

FF 119.0.1

Operating System and version

Win 10

[garry-ut99]

Related AdGuard request:

• Improve 'trusted-click-element' — add support for finding selectors in shadowRoot AdguardTeam/Scriptlets#323

[gorhill]

Works in latest dev build: racingnews365.com##+js(trusted-click-element, #cmpwrapper >>> .cmpboxbtnyes)

[peace2000]

@gorhill This works, thanks.

However, if we want to do multiple clicks (customize settings) then we have to type >>> command many times.

Should we assume that all the selectors are inside the same shadow dom if >>> is being used inside the same quote??

So, instead of this:
racingnews365.com##+js(trusted-click-element, '#cmpwrapper >>> .cmptxt_btn_settings, #cmpwrapper >>> [data-cmp-purpose="1"][aria-checked="false"], #cmpwrapper >>> .cmptxt_btn_save')

The syntax would be:

racingnews365.com##+js(trusted-click-element, '#cmpwrapper >>> .cmptxt_btn_settings, [data-cmp-purpose="1"][aria-checked="false"], .cmptxt_btn_save')

[gorhill]

I prefer to leave it as is. If ever there is a case where an selector in the sequence has to apply outside a shadow root, there would be no workaround. Also, >>> is recursive, it would become very difficult to predict what would be the behavior for subsequent selectors at different level of shadow root.

Consider >>> to be no different than > (>>> actually used to exist before it was deprecated), so the same way you may be forced to repeat > usage where needed, do the same for >>>.

[dportvine]

racingnews365.com##+js(trusted-click-element, '#cmpwrapper >>> .cmptxt_btn_settings, #cmpwrapper >>> [data-cmp-purpose="1"][aria-checked="false"], #cmpwrapper >>> .cmptxt_btn_save')

In the logger this rule looks different, but it works.

racingnews365.com##+js(trusted-click-element, #cmpwrapper >>> .cmptxt_btn_settings\, #cmpwrapper >>> [data-cmp-purpose="1"][aria-checked="false"]\, #cmpwrapper >>> .cmptxt_btn_save)

[peace2000]

uBO's logger reports quoted values as if the commas have been escaped in them. This happens also with E.G. set-cookie scriptlets.

It doesn't make a difference how they look like, though I think quoted values in the logger look better than escaped ones. Besides, using quoted values has become more popular at uAssets than using escaped commas.

[peace2000]

@gorhill Shadow-piercing doesn't work well on this page: https://myprivacy.dpgmediagroup.net

It takes many seconds for uBO to click the first button. The following buttons are never clicked.

To access that page, must open this page: dpgmedia.nl

Filter used:

myprivacy.dpgmediagroup.net##+js(trusted-click-element, '#pg-shadow-host >>> #pg-configure-btn, #pg-shadow-host >>> #purpose-row-SOCIAL_MEDIA input[type="checkbox"], #pg-shadow-host >>> button#pg-save-preferences-btn', , , log, 1)

Buttons that are supposed to click:

1. Instellen
2. Sociale media
3. Voorkeuren opslaan

Console:

@peace2000 I'm landing on https://www.dpgmediagroup.com/nl-NL.

---

If I use www.dpgmediagroup.com##..., the first button is clicked and dialog disappears, not much happens then. If I then clear cookies and reload, I'm redirected to myprivacy.dpgmediagroup.net, first button is clicked correctly again, but I cannot find the second selector in the source.

[peace2000]

I saw that .com variant as well but it stopped appearing after I cleared cache.

[peace2000]

but I cannot find the second selector in the source.

You don't have this?