Skip to content

Exceptor widget in the logger UI doesn't work on HTML filters in the dev build #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
uBlock-user opened this issue Dec 7, 2021 · 3 comments
Closed
8 tasks done
Labels
bug Something isn't working Firefox specific to Firefox fixed issue has been addressed

Comments

@uBlock-user
Copy link
Contributor

uBlock-user commented Dec 7, 2021

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

As the title implies.

A specific URL where the issue occurs

https://www.naturalblaze.com/

Steps to Reproduce

filterAuthorMode must be set to true first.

  • Browse to https://www.naturalblaze.com/ in a new tab and open the logger in another.
  • Add www.naturalblaze.com##^#custom_html-7
    to my filters and refresh the page, then click on ##^#custom_html-7 filter to summon netFilteringDialog box and then click on the exceptor widget
  • Notice filter doesn't get disabled(no strikethrough line over the filter), nothing happens.

Expected behavior

Filter gets disabled(strikethrough line over the filter)

Actual behavior

Filter doesn't get disabled(no strikethrough line over the filter)

uBlock Origin version

1.39.3b4

Browser name and version

Firefox 96

Operating System and version

Win 10

@uBlock-user uBlock-user added the bug Something isn't working label Dec 7, 2021
@uBlock-user
Copy link
Contributor Author

uBlock-user commented Dec 7, 2021

As reported first at uBlockOrigin/uAssets#10788 (comment)

@uBlock-user uBlock-user added the Firefox specific to Firefox label Dec 7, 2021
@uBlock-user uBlock-user removed the Firefox specific to Firefox label Sep 12, 2022
@uBlock-user uBlock-user added the Firefox specific to Firefox label Nov 20, 2022
@uBlock-user
Copy link
Contributor Author

uBlock-user commented Nov 20, 2022

Last working build - https://github.com/gorhill/uBlock/releases/tag/1.39.0

@gorhill Seems gorhill/uBlock@1ac9c5c was the commit where regression happened.

gorhill added a commit to gorhill/uBlock that referenced this issue Dec 14, 2022
Related issue:
- uBlockOrigin/uBlock-issues#1861

The "exceptor" feature has been rewritten, with the following
changes as a result:

- The excepted filters cease to exist when closing the logger
- It's now possible to temporary except network filters

When toggling on/off a temporary exception, filter lists are now
fully reloaded. This simplified managing temporary exceptions, and
made it easy to implement temporary exception for network filters,
but this also means there might be a perceptible delay when
adding/removing temporary exceptions. At this point I consider
this an acceptable side-effect just to bring the ability to easily
create temporary exception for network filters, while this
simplified the existing temporary exception code throughout.
uBlock-user referenced this issue in gorhill/uBlock Dec 15, 2022
Related feedback:
- a91781a#commitcomment-93128519

For instance, do not make exceptor widget available for
exceptions from filter lists.
@uBlock-user uBlock-user added the fixed issue has been addressed label Dec 15, 2022
@MasterKia
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Firefox specific to Firefox fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

2 participants