-
Notifications
You must be signed in to change notification settings - Fork 86
Exceptor widget in the logger UI doesn't work on HTML filters in the dev build #1861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
8 tasks done
Comments
As reported first at uBlockOrigin/uAssets#10788 (comment) |
6 tasks
Last working build - https://github.com/gorhill/uBlock/releases/tag/1.39.0 @gorhill Seems gorhill/uBlock@1ac9c5c was the commit where regression happened. |
gorhill
added a commit
to gorhill/uBlock
that referenced
this issue
Dec 14, 2022
Related issue: - uBlockOrigin/uBlock-issues#1861 The "exceptor" feature has been rewritten, with the following changes as a result: - The excepted filters cease to exist when closing the logger - It's now possible to temporary except network filters When toggling on/off a temporary exception, filter lists are now fully reloaded. This simplified managing temporary exceptions, and made it easy to implement temporary exception for network filters, but this also means there might be a perceptible delay when adding/removing temporary exceptions. At this point I consider this an acceptable side-effect just to bring the ability to easily create temporary exception for network filters, while this simplified the existing temporary exception code throughout.
uBlock-user
referenced
this issue
in gorhill/uBlock
Dec 15, 2022
Related feedback: - a91781a#commitcomment-93128519 For instance, do not make exceptor widget available for exceptions from filter lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
I tried to reproduce the issue when...
Description
As the title implies.
A specific URL where the issue occurs
https://www.naturalblaze.com/
Steps to Reproduce
filterAuthorMode
must be set totrue
first.https://www.naturalblaze.com/
in a new tab and open the logger in another.www.naturalblaze.com##^#custom_html-7
to my filters and refresh the page, then click on
##^#custom_html-7
filter to summon netFilteringDialog box and then click on the exceptor widgetExpected behavior
Filter gets disabled(strikethrough line over the filter)
Actual behavior
Filter doesn't get disabled(no strikethrough line over the filter)
uBlock Origin version
1.39.3b4
Browser name and version
Firefox 96
Operating System and version
Win 10
The text was updated successfully, but these errors were encountered: