Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locator support to alphanumeric style #298

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Eloitor
Copy link

@Eloitor Eloitor commented Mar 30, 2025

Fixes #48

Copy link
Contributor

@PgBiel PgBiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you add a test like this one?

fn test_alphanumeric_disambiguation() {

<group delimiter=", ">
<text variable="citation-label"/>
<text variable="year-suffix"/>
<text variable="locator" prefix=" " />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for the nested group with the same delimiter and this prefix? What is your intended output?

Of note, @citation[abc] produced [Cit25a, abc] in Typst 0.8.0, before the regression. We should probably stick to that.

@Eloitor
Copy link
Author

Eloitor commented Apr 1, 2025

what should be the output of @first[abc] @second[def]?

@Eloitor
Copy link
Author

Eloitor commented Apr 1, 2025

I attempted to add a test, but I don't know if it is possible (or necessary) to specify create a location in a BibliographyRequest...

       let finished = driver.finish(BibliographyRequest {
            style: &alphanumeric,
            locale: None,
            locale_files: &[],
        });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alphanumerical citation style ignores supplement
2 participants