Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alphanumerical citation style ignores supplement #48

Open
lynn opened this issue May 29, 2023 · 2 comments · Fixed by #49 · May be fixed by #298
Open

Alphanumerical citation style ignores supplement #48

lynn opened this issue May 29, 2023 · 2 comments · Fixed by #49 · May be fixed by #298

Comments

@lynn
Copy link
Contributor

lynn commented May 29, 2023

From typst/typst#1330.

CitationStyle::citation for Alphanumeric doesn't inspect atomic.supplement inside the for atomic in parts loop.

Maybe it simply needs something like:

+           if let Some(supplement) = atomic.supplement {
+              res += ", ";
+              res += supplement;
+           }
            items.push(res);

…but maybe it's more complicated than that.
This was referenced May 29, 2023
Closed
Merged
@laurmaedje laurmaedje reopened this May 7, 2024
@laurmaedje
Copy link
Member

The alphanumeric CSL style doesn't have a citation-locator, which regressed this.

@IEncinas10
Copy link

Hello! I'm writing my thesis with typst and I would like to have this working.

I dont know how hard is to fix this issue because I'm unfamiliar with the codebase, but if is not too complicated I would appreciate a few pointers and give it a try.

Thanks!

@EpicEricEE EpicEricEE mentioned this issue Jan 15, 2025
Closed
1 task
@Eloitor Eloitor linked a pull request Mar 30, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lynn @laurmaedje @IEncinas10