Fix colors not showing #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes the ` ` on newlines.
j-f1
reviewed
Jan 21, 2018
| @@ -1 +1 @@ | |||
| setInterval(() => console.log(Math.random()), 100) | |||
| setInterval(() => console.log('[31m' + Math.random() + '\n'), 200) | |||
There was a problem hiding this comment.
Does this have an escape character in it? If so, can you put it in the string with a backslash escape so it’s easier to read?
There was a problem hiding this comment.
Sorry, I don't really get what you mean. Nothing in the string needs escaping.
src/app/formatter.ts
Outdated
| @@ -12,7 +11,6 @@ export function formatLines(str: string): string[] { | |||
| .split('\n') | |||
| .map(blankLine) | |||
| .map(ansi2HTML) | |||
| .map(escapeHTML) | |||
There was a problem hiding this comment.
Does this open Hotel up to XSS attacks?
There was a problem hiding this comment.
Hmm I would say risks are low, but would feel safer with html escaped.
Without speaking of attacks, if you have some tags, like <h1> in your output, it will "break" output style.
If I'm not wrong, modern front-end tools, like create-react-app, tend to log JSX in the output if there are errors.
Also add proper types to fix type errors
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes the
on newlines.See #196