Skip to content

Test under Java 25 #7113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Jun 27, 2025
Merged

Test under Java 25 #7113

merged 40 commits into from
Jun 27, 2025

Conversation

mernst
Copy link
Member

@mernst mernst commented Jun 21, 2025

Pull from master after #7130 is merged.

@mernst
Copy link
Member Author

mernst commented Jun 21, 2025

@smillst Could you take a look at this?

Copy link
Member

@smillst smillst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I changed the test scripts to run Gradle with JDK 21 and so now we need to set the jdkTestVersion to the jdk version we wish to test. I added a comment explaining this.

@smillst smillst assigned mernst and unassigned smillst Jun 25, 2025
@mernst mernst assigned smillst and unassigned mernst Jun 26, 2025
@mernst
Copy link
Member Author

mernst commented Jun 27, 2025

@smillst Can you take a look at the (currently commented out) misc_jdk11 job to see whether it is possible to reinstate?
Here is the error: https://dev.azure.com/checkerframework/checkerframework/_build/results?buildId=18357&view=logs&j=4b19ccca-7d7d-5749-26de-b87349fba2b4&t=4dba1f6c-8e7b-5172-04db-4dd554c55b12

@smillst
Copy link
Member

smillst commented Jun 27, 2025

@smillst Can you take a look at the (currently commented out) misc_jdk11 job to see whether it is possible to reinstate? Here is the error: https://dev.azure.com/checkerframework/checkerframework/_build/results?buildId=18357&view=logs&j=4b19ccca-7d7d-5749-26de-b87349fba2b4&t=4dba1f6c-8e7b-5172-04db-4dd554c55b12

I've fixed this and I reinstated the misc_jdk11 job.

@smillst smillst removed their assignment Jun 27, 2025
smillst
smillst previously approved these changes Jun 27, 2025
@mernst
Copy link
Member Author

mernst commented Jun 27, 2025

@smillst please review and enable auto-merge. Thanks!

@smillst smillst enabled auto-merge (squash) June 27, 2025 20:05
@smillst smillst merged commit 9b51e58 into typetools:master Jun 27, 2025
21 checks passed
@smillst smillst deleted the java25 branch June 27, 2025 21:07
wmdietl pushed a commit to eisop/checker-framework that referenced this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants