Skip to content

build before launch in Debug Extension #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2021
Merged

build before launch in Debug Extension #97

merged 1 commit into from
Mar 30, 2021

Conversation

jamescdavis
Copy link
Member

This adds a preLaunchTask to run build before launching the extension development host.

@jamescdavis jamescdavis requested a review from dfreeman March 30, 2021 15:47
@dfreeman dfreeman added the internal Changes that don't impact the published packages label Mar 30, 2021
dfreeman
dfreeman approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@dfreeman dfreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pretty much always have yarn build --watch running when I'm working in Glint, but this seems like a useful addition for everyone who has other things to do with their day 😄

@jamescdavis jamescdavis merged commit c8c3f97 into master Mar 30, 2021
@jamescdavis jamescdavis deleted the prelaunch_build branch March 30, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfreeman dfreeman dfreeman approved these changes

Assignees
No one assigned
Labels
internal Changes that don't impact the published packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamescdavis @dfreeman