Restore previous approach to glint-* directives atop new TS Plugin architecture #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TS Plugin-friendly approach to (re-)implementing directives (e.g.
{{@glint-expect-error ...}}) that I borrowed from Vue has a number of issues, in particular sometimes it breaks the syntax of the transformed TS because it outputs top-level statements in the middle of where an expression is expected in certain cases.Fortunately in the meantime I was able to get some feedback from the Volar/Vue team as to how to reinstate essentially the previous Glint 1 algorithm/behavior for directives but have it work atop TS Plugin. This PR implements this "hybrid" approach and should faithfully reinstate Glint V1's algorithm, which seemed to work well enough for everyone.