Skip to content

Re-enable type-tests #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,18 @@ jobs:
- run: pnpm lint
- uses: wyvox/action-setup-pnpm@v3

# type-tests:
# name: "Type Tests"
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - uses: pnpm/action-setup@v2
# - uses: actions/setup-node@v4
# with:
# cache: pnpm
# - run: pnpm reset
# - run: "pnpm --filter '*' run test:typecheck"
# - run: "pnpm --filter '*' run test:tsc"
type-tests:
name: "Type Tests"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v2
- uses: actions/setup-node@v4
with:
cache: pnpm
- run: pnpm reset
- run: "pnpm --filter '*' run test:typecheck"
- run: "pnpm --filter '*' run test:tsc"

test:
name: Test
Expand Down
7 changes: 0 additions & 7 deletions packages/environment-ember-loose/__tests__/tsconfig.json

This file was deleted.

24 changes: 16 additions & 8 deletions packages/environment-ember-loose/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,27 @@
"author": "Dan Freeman (https://github.com/dfreeman)",
"main": "-private/index.js",
"exports": {
".": "./-private/index.js",
"./registry": "./registry/index.js",
"./glint-environment-definition": "./-private/environment/index.js",
"./-private/dsl": "./-private/dsl/index.js"
".": {
"types": "./-private/index.d.ts",
"default": "./-private/index.js"
},
"./registry": {
"types": "./registry/index.d.ts",
"default": "./registry/index.js"
},
"./glint-environment-definition": {
"types": "./-private/environment/index.d.ts",
"default": "./-private/environment/index.js"
},
"./-private/dsl": {
"types": "./-private/dsl/index.d.ts",
"default": "./-private/dsl/index.js"
}
},
"keywords": [
"glint-environment"
],
"scripts": {
"test": "echo 'no tests within this project'",
"test:tsc": "echo 'no standalone typecheck within this project'",
"test:typecheck": "glint --project __tests__/type-tests && vitest run",
"test:watch": "vitest watch",
"build": "tsc --build",
"prepack": "pnpm build"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/template/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@
"html-element-attributes": "^3.3.0",
"html-event-attributes": "^2.2.0",
"svg-element-attributes": "^2.1.0",
"svg-event-attributes": "^2.0.2"
"svg-event-attributes": "^2.0.2",
"expect-type": "^0.15.0",
"sums-up": "^2.1.0"
},
"publishConfig": {
"access": "public"
Expand Down
3 changes: 1 addition & 2 deletions packages/template/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{
"extends": "../../tsconfig.compileroptions.json",
"exclude": ["__tests__"]
"extends": "../../tsconfig.compileroptions.json"
}
6 changes: 5 additions & 1 deletion packages/type-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@
"@glint/template": "*"
},
"devDependencies": {
"@glint/template": "workspace:*"
"@glint/core": "workspace:*",
"@glint/environment-ember-loose": "workspace:*",
"@glint/environment-ember-template-imports": "workspace:*",
"@glint/template": "workspace:*",
"ember-source": "^6.3.0"
},
"publishConfig": {
"access": "public"
Expand Down
3 changes: 2 additions & 1 deletion packages/type-test/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"extends": "../../tsconfig.compileroptions.json",
"compilerOptions": {
"rootDir": "src",
"outDir": "lib"
"outDir": "lib",
"types": ["ember-source/types"],
},
"include": ["src"],
"references": [{ "path": "../template" }]
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export {};
//# sourceMappingURL=environment.test.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { describe, test, expect } from 'vitest';
import envDefinition from '../-private/environment/index.js';
import envDefinition from '@glint/environment-ember-loose/glint-environment-definition';

describe('Environments: Ember Loose', () => {
test.each(['ts', 'js'])('finds possible template paths for %s script paths', (ext) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export {};
//# sourceMappingURL=ember-component.test.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export {};
//# sourceMappingURL=glimmer-component.test.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading