Simplify specifying block params #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reworks how block signatures are specified, going from this:
...to this:
This eliminates the need for the useless
BlockResult
dummy type. It may appear to lose useful information in the form of parameter names, but in fact that already disappears as the type is transformed, and it will also be possible in TS 4 to label tuple elements.It also (unfortunately) includes a refactoring to reorganize built-in template entities like
let
andeach
. Ideally I would have landed that separately, but by the time I realized how much of an impact these two changes would have individually they were already tangled up with one another.Regardless, I think there's likely to be further refactoring of these things in the future, since the items available look fairly different between GlimmrX, Glimmer.js, and Ember.