Skip to content

Adding an untyped GlimmerX project to develop the GlimmerX language server against #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2021

Conversation

erinsinger93
Copy link
Collaborator

Created a basic GlimmerX project that doesn't utilize typescript so we can adapt language server features to work for non-typescript projects. The bulk of added code in the new directory is the boilerplate that comes free with new glimmer blueprints.

I couldn't decide if the phrase "untyped" or "vanilla-js" was more appropriate. Please weigh in on any naming changes you might prefer.

This project uses the latest version of GlimmerX and makes use of tracked properties, modifiers, components as args, and helpers as plain JS functions.

As of right now when testing this dummy app with the current language server, it seems none of the template functionality that works for typed Glimmer work properly for untyped Glimmer, so the next steps will be investigating these points of failure and planning a sane pathway forward that works for both the Glint charter as well as the untyped Glimmer language server charter.

@erinsinger93
Copy link
Collaborator Author

I'll investigate that test error as I wasn't getting that locally. Looks like a dependency issue.

@dfreeman dfreeman added the internal Changes that don't impact the published packages label Mar 17, 2021
Copy link
Member

@dfreeman dfreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erinsinger93! This totally makes sense to me to use as a starting point for working on JS support.

@jamescdavis
Copy link
Member

🤔 appears to be hung on Windows:
Screen Shot 2021-03-18 at 10 46 04 AM

@dfreeman
Copy link
Member

I just ended the CI run so it would stop eating our Actions minutes. Off the top of my head I can't think of a reason this app would hang on Windows when the other GlimmerX one doesn't 🤔

@erinsinger93
Copy link
Collaborator Author

erinsinger93 commented Mar 18, 2021

(for the prettier issue)

It may have been because in the package.json eslintConfig I need to include

"overrides": [
   {
      "files": [
         ".babelrc.js",
         "testem.js",
         "webpack.config.js"
     ],
     "env": {
         "node": true
      }
   }
]

like we have in the other demo apps

@erinsinger93 erinsinger93 requested a review from dfreeman March 18, 2021 20:13
@jamescdavis jamescdavis mentioned this pull request Mar 18, 2021
Copy link
Member

@dfreeman dfreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@erinsinger93 erinsinger93 merged commit 21c5c93 into master Mar 18, 2021
@erinsinger93 erinsinger93 deleted the untyped-glimmerx branch March 18, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes that don't impact the published packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants