-
Notifications
You must be signed in to change notification settings - Fork 58
Adding an untyped GlimmerX project to develop the GlimmerX language server against #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll investigate that test error as I wasn't getting that locally. Looks like a dependency issue. |
ffe0652
to
d35e9a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @erinsinger93! This totally makes sense to me to use as a starting point for working on JS support.
I just ended the CI run so it would stop eating our Actions minutes. Off the top of my head I can't think of a reason this app would hang on Windows when the other GlimmerX one doesn't 🤔 |
(for the prettier issue) It may have been because in the package.json eslintConfig I need to include
like we have in the other demo apps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a basic GlimmerX project that doesn't utilize typescript so we can adapt language server features to work for non-typescript projects. The bulk of added code in the new directory is the boilerplate that comes free with new glimmer blueprints.
I couldn't decide if the phrase "untyped" or "vanilla-js" was more appropriate. Please weigh in on any naming changes you might prefer.
This project uses the latest version of GlimmerX and makes use of tracked properties, modifiers, components as args, and helpers as plain JS functions.
As of right now when testing this dummy app with the current language server, it seems none of the template functionality that works for typed Glimmer work properly for untyped Glimmer, so the next steps will be investigating these points of failure and planning a sane pathway forward that works for both the Glint charter as well as the untyped Glimmer language server charter.