Skip to content

Break out reexports by path #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2021
Merged

Break out reexports by path #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f42cab3
Break out environment-ember-loose reexports by path
dfreeman Mar 12, 2021
949abbb
Break out environment-glimmerx reexports by path
dfreeman Mar 12, 2021
83b1394
Update test suite imports
dfreeman Mar 12, 2021
2ac2d69
Update demo app imports
dfreeman Mar 12, 2021
95dc240
Fixup lint config for environment packages
dfreeman Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/core/__tests__/cli/check.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('CLI: single-pass typechecking', () => {

test('passes a valid project', async () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

type ApplicationArgs = {
version: string;
Expand All @@ -42,7 +42,7 @@ describe('CLI: single-pass typechecking', () => {

test('reports diagnostics for a template syntax error', async () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

type ApplicationArgs = {
version: string;
Expand Down Expand Up @@ -78,7 +78,7 @@ describe('CLI: single-pass typechecking', () => {

test('reports diagnostics for an inline template type error', async () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

type ApplicationArgs = {
version: string;
Expand Down Expand Up @@ -118,13 +118,13 @@ describe('CLI: single-pass typechecking', () => {
project.write('.glintrc', 'environment: ember-loose\n');

let script = stripIndent`
import { EmberComponent } from '@glint/environment-ember-loose';
import Component from '@glint/environment-ember-loose/ember-component';

export type MyComponentArgs = {
message: string;
};

export default class MyComponent extends EmberComponent<{ Args: MyComponentArgs }> {
export default class MyComponent extends Component<{ Args: MyComponentArgs }> {
target = 'World!';
}
`;
Expand Down Expand Up @@ -156,7 +156,7 @@ describe('CLI: single-pass typechecking', () => {

test('honors .glintrc configuration', async () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export default class Application extends Component {
public static template = hbs\`
Expand Down
4 changes: 2 additions & 2 deletions packages/core/__tests__/cli/declaration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe('CLI: emitting declarations', () => {

test('emit for a valid project', async () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export type ApplicationArgs = {
version: string;
Expand All @@ -37,7 +37,7 @@ describe('CLI: emitting declarations', () => {
expect(emitResult.exitCode).toBe(0);

expect(project.read('index.d.ts')).toMatchInlineSnapshot(`
"import { Component } from '@glint/environment-glimmerx';
"import Component from '@glint/environment-glimmerx/component';
export declare type ApplicationArgs = {
version: string;
};
Expand Down
12 changes: 6 additions & 6 deletions packages/core/__tests__/cli/watch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('CLI: watched typechecking', () => {

test('passes a valid project', async () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

type ApplicationArgs = {
version: string;
Expand Down Expand Up @@ -44,7 +44,7 @@ describe('CLI: watched typechecking', () => {

test('reports diagnostics for a template syntax error', async () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

type ApplicationArgs = {
version: string;
Expand Down Expand Up @@ -87,7 +87,7 @@ describe('CLI: watched typechecking', () => {

test('reports diagnostics for a template type error', async () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

type ApplicationArgs = {
version: string;
Expand Down Expand Up @@ -131,7 +131,7 @@ describe('CLI: watched typechecking', () => {

test('reports on errors introduced and cleared during the watch', async () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

type ApplicationArgs = {
version: string;
Expand Down Expand Up @@ -172,13 +172,13 @@ describe('CLI: watched typechecking', () => {
project.write('index.ts', 'import "@glint/environment-ember-loose/types";');

let script = stripIndent`
import { EmberComponent } from '@glint/environment-ember-loose';
import Component from '@glint/environment-ember-loose/ember-component';

export type MyComponentArgs = {
message: string;
};

export default class MyComponent extends EmberComponent<{ Args: MyComponentArgs }> {
export default class MyComponent extends Component<{ Args: MyComponentArgs }> {
target = 'World!';
}
`;
Expand Down
10 changes: 5 additions & 5 deletions packages/core/__tests__/language-server/completions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('Language Server: Completions', () => {

test('passing component args', () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export default class MyComponent extends Component {
static template = hbs\`
Expand Down Expand Up @@ -53,7 +53,7 @@ describe('Language Server: Completions', () => {

test('referencing class properties', () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export default class MyComponent extends Component {
private message = 'hello';
Expand Down Expand Up @@ -83,7 +83,7 @@ describe('Language Server: Completions', () => {

test('referencing own args', async () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

type MyComponentArgs<T> = {
items: Set<T>;
Expand Down Expand Up @@ -115,7 +115,7 @@ describe('Language Server: Completions', () => {

test('referencing block params', async () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export default class MyComponent extends Component {
static template = hbs\`
Expand Down Expand Up @@ -145,7 +145,7 @@ describe('Language Server: Completions', () => {

test('referencing module-scope identifiers', async () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

const greeting: string = 'hello';

Expand Down
14 changes: 7 additions & 7 deletions packages/core/__tests__/language-server/definitions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ describe('Language Server: Definitions', () => {
test('component invocation', () => {
project.write({
'greeting.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';
export default class Greeting extends Component<{ Args: { message: string } }> {
static template = hbs\`{{@message}}, World!\`;
}
`,
'index.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';
import Greeting from './greeting';

export default class Application extends Component {
Expand Down Expand Up @@ -53,7 +53,7 @@ describe('Language Server: Definitions', () => {
test('arg passing', () => {
project.write({
'greeting.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export type GreetingArgs = {
message: string;
Expand All @@ -64,7 +64,7 @@ describe('Language Server: Definitions', () => {
}
`,
'index.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';
import Greeting from './greeting';

export default class Application extends Component {
Expand Down Expand Up @@ -95,7 +95,7 @@ describe('Language Server: Definitions', () => {
test('arg use', () => {
project.write({
'greeting.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export type GreetingArgs = {
message: string;
Expand Down Expand Up @@ -127,7 +127,7 @@ describe('Language Server: Definitions', () => {
test('import source', () => {
project.write({
'greeting.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export type GreetingArgs = {
message: string;
Expand All @@ -138,7 +138,7 @@ describe('Language Server: Definitions', () => {
}
`,
'index.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';
import Greeting from './greeting';

export class Application extends Component {
Expand Down
4 changes: 2 additions & 2 deletions packages/core/__tests__/language-server/diagnostics.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('Language Server: Diagnostics', () => {

test('reports diagnostics for an inline template type error', () => {
let code = stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

type ApplicationArgs = {
version: string;
Expand Down Expand Up @@ -83,7 +83,7 @@ describe('Language Server: Diagnostics', () => {

test('reports diagnostics for a companion template type error', () => {
let script = stripIndent`
import { Component } from '@glint/environment-glimmerx';
import Component from '@glint/environment-glimmerx/component';

type ApplicationArgs = {
version: string;
Expand Down
6 changes: 3 additions & 3 deletions packages/core/__tests__/language-server/hover.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('Language Server: Hover', () => {
test('using private properties', () => {
project.write({
'index.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export default class MyComponent extends Component {
/** A message. */
Expand Down Expand Up @@ -48,7 +48,7 @@ describe('Language Server: Hover', () => {
test('using args', () => {
project.write({
'index.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

interface MyComponentArgs {
/** Some string */
Expand Down Expand Up @@ -85,7 +85,7 @@ describe('Language Server: Hover', () => {
test('curly block params', () => {
project.write({
'index.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export default class MyComponent extends Component {
static template = hbs\`
Expand Down
8 changes: 4 additions & 4 deletions packages/core/__tests__/language-server/references.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('Language Server: References', () => {
test('component references', () => {
project.write({
'greeting.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export default class Greeting extends Component {
private nested = Math.random() > 0.5;
Expand All @@ -31,7 +31,7 @@ describe('Language Server: References', () => {
}
`,
'index.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';
import Greeting from './greeting';

export default class Application extends Component {
Expand Down Expand Up @@ -92,7 +92,7 @@ describe('Language Server: References', () => {
test('arg references', async () => {
project.write({
'greeting.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export type GreetingArgs = {
/** Who to greet */
Expand All @@ -106,7 +106,7 @@ describe('Language Server: References', () => {
}
`,
'index.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';
import Greeting from './greeting';

export default class Application extends Component {
Expand Down
12 changes: 6 additions & 6 deletions packages/core/__tests__/language-server/rename.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('Language Server: Renaming Symbols', () => {
test('preparing rename-able and unrename-able elements', () => {
project.write({
'index.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

type GreetingArgs = {
message: string;
Expand Down Expand Up @@ -55,7 +55,7 @@ describe('Language Server: Renaming Symbols', () => {
test('renaming an arg', () => {
project.write({
'greeting.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export type GreetingArgs = {
message: string;
Expand All @@ -66,7 +66,7 @@ describe('Language Server: Renaming Symbols', () => {
}
`,
'index.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';
import Greeting from './greeting';

export class Application extends Component {
Expand Down Expand Up @@ -139,7 +139,7 @@ describe('Language Server: Renaming Symbols', () => {
test('renaming a block param', () => {
project.write({
'index.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export default class Application extends Component {
static template = hbs\`
Expand Down Expand Up @@ -195,7 +195,7 @@ describe('Language Server: Renaming Symbols', () => {
test('renaming a component', async () => {
project.write({
'greeting.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export type GreetingArgs = {
message: string;
Expand All @@ -206,7 +206,7 @@ describe('Language Server: Renaming Symbols', () => {
}
`,
'index.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';
import Greeting from './greeting';

export class Application extends Component {
Expand Down
4 changes: 2 additions & 2 deletions packages/core/__tests__/language-server/symbol-search.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe('Language Server: Symbol Search', () => {
test('component definition', () => {
project.write({
'greeting.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';

export type GreetingArgs = {
message: string;
Expand All @@ -28,7 +28,7 @@ describe('Language Server: Symbol Search', () => {
}
`,
'index.ts': stripIndent`
import { Component, hbs } from '@glint/environment-glimmerx';
import Component, { hbs } from '@glint/environment-glimmerx/component';
import Greeting from './greeting';

export class Application extends Component {
Expand Down
3 changes: 2 additions & 1 deletion packages/environment-ember-loose/.eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
/lib/
/*/*.js
/*/*.d.ts
5 changes: 4 additions & 1 deletion packages/environment-ember-loose/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
lib/
*.js
*.d.ts
tsconfig.tsbuildinfo

!types/**/*.d.ts
2 changes: 2 additions & 0 deletions packages/environment-ember-loose/.prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/*/*.js
/*/*.d.ts
Loading