Skip to content

Improve error reporting when failing to associate a companion template #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

dfreeman
Copy link
Member

@dfreeman dfreeman commented Mar 9, 2021

Quick bugfix for something I ran into working on typesafe reexports. The "you need a default export" error message was only being generated inside the traversal callback for an ExportDefaultDeclaration, which obviously caused issues.

This error is now split in two: one when no default export is present at all, and one when it's not a syntactic form we know how to deal with.

@dfreeman dfreeman added the bug Something isn't working label Mar 9, 2021
@dfreeman dfreeman merged commit e67b4ac into master Mar 9, 2021
@dfreeman dfreeman deleted the default-export-error-reporting branch March 10, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant