More robust error handling in the language server #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a handful of scenarios where the language server wasn't behaving well in actual usage.
GlintLanguageServer
are caught and logged, and a sensible "no answer" response is sent instead@glimmer/syntax
gives entirely different errors based on whether the syntax problem came from the handlebars parser or the secondary HTML layer. We now no longer choke on the latter type, and make a best-effort attempt to extract the error location in that scenario as well.Internal error: offset out of bounds
when an LSP request comes in on a template file with syntax errorsI think this hits all the known crash points we've run into so far, though I'm sure there are others lurking in slightly less obvious corners.