Skip to content

Support standalone template files in @glint/cli #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2020

Conversation

dfreeman
Copy link
Member

Overview

This PR introduces support for typechecking separate template files from the CLI, as well as adding the required functionality to @glint/transform to support that.

standalone

Notes and Caveats

  • If you look at 36ab4d8, I'd recommend doing it with ?w=1, as it involved restructuring some test modules
  • This doesn't include support for template-only components, as there are still some design questions to be answered about how that works. (Is anything about that environment-specific? How are types for args/yields/etc specified?)
  • This doesn't include any updates to the tsserver plugin (other than matching an API change in @glint/transform), which will require several additional steps to support

@jamescdavis 0b82ced is the commit that updates the CLI itself. The main things happening there are ensuring that watching a probable component script also sets up a watch for its potential template files, and that reading a probable component script also reads the corresponding template.

@dfreeman dfreeman added the enhancement New feature or request label Dec 12, 2020
@dfreeman dfreeman merged commit 4fca02a into master Dec 12, 2020
@dfreeman dfreeman deleted the transform-companion-templates branch December 12, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant