Use original module resolution #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the results of template transformation could affect the type of a component, it was important that imported symbols in other modules reflect that type information. To accomplish that, the tsserver plugin caused all imports to resolve to a transformed version of the module they were targeting, re-exporting the contents of the original module if no transformation was needed.
One side effect of this was that we needed to implement merging for auto-import actions ourselves (#7), because TS would always see the existing import statements in a file as belonging to the transformed modules, while the incoming symbols would be from the original.
This should fix #11, since we're no longer changing the default auto-import behavior at all.