Skip to content

Solve 'The Mystery of the Missing app.js 🕵️‍♂️' #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Solve 'The Mystery of the Missing app.js 🕵️‍♂️' #89

merged 1 commit into from
Jan 24, 2018

Conversation

dfreeman
Copy link
Member

Incremental compilation was broken because app.js was being transformed into a file just called js.

This should also fix things when using a linked copy e-c-ts. The serve-ts diff is nasty, but all I did was wrap the module in a function so it could use project.require() to ensure the CLI imports always resolve to the host app's copy.

@chriskrycho
Copy link
Member

OH MY GOSH. Hero.

@dwickern
Copy link
Contributor

Thanks for figuring this out! So we are importing relative to the project root instead of process.cwd.

(also FYI you can add ?w=1 to the github diff URL to ignore whitespace)

@dfreeman
Copy link
Member Author

(also FYI you can add ?w=1 to the github diff URL to ignore whitespace)

This has to be about the fourth time I've learned that trick, but I always forget about it again by the next time I need it 🤦‍♂️

@dwickern dwickern merged commit 3f722d9 into typed-ember:fast-incremental-compiler Jan 24, 2018
@dfreeman dfreeman deleted the fast-incremental-compiler branch January 24, 2018 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants