Skip to content

test on python 3.12 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 26, 2023
Merged

test on python 3.12 #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5bea4b4
test on python 3.12
graingert Oct 26, 2023
7ed308d
test the build
graingert Oct 26, 2023
913aa03
run pipx run versioneer install --no-vendor
graingert Oct 26, 2023
caea17e
switch to pyproject versioneer
graingert Oct 26, 2023
a2283ed
avoid deprecated call to setup.py
graingert Oct 26, 2023
1f43176
new versioneer is py3 only
graingert Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11']
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']

steps:
- uses: actions/checkout@v3
Expand All @@ -54,10 +54,13 @@ jobs:
python-version: ${{ matrix.python-version }}
allow-prereleases: true

- name: Test build
run: pipx run --python=python build .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that build is called before the deps are installed.

Is that ok ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pipx manages the deps


- name: Install dependencies
run: |
openssl version
python -m pip install --upgrade twisted coverage
python -m pip install --upgrade twisted coverage build

- name: Test
run: |
Expand Down Expand Up @@ -161,9 +164,8 @@ jobs:

- name: Build
run: |
python -m pip install --upgrade pip wheel pep517
rm -rf dist/*
python setup.py bdist_wheel sdist
pipx run --python=python build .

- name: Files to be pushed to PyPi
run: ls -R dist/
Expand Down
5 changes: 2 additions & 3 deletions constantly/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@
NamedConstant, Names, ValueConstant, Values, FlagConstant, Flags
)

from ._version import get_versions
__version__ = get_versions()['version']
del get_versions
from . import _version
__version__ = _version.get_versions()['version']

__author__ = "Twisted Matrix Laboratories"
__license__ = "MIT"
Expand Down
Loading