Skip to content

fix: deprecation warning on Faraday #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

ngouy
Copy link
Contributor

@ngouy ngouy commented Aug 30, 2021

warning:

WARNING: Faraday::Connection#basic_auth is deprecated; it will be removed in version 2.0.
While initializing your connection, use #request(:basic_auth, ...) instead.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.

image

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

warning:
> WARNING: `Faraday::Connection#basic_auth` is deprecated; it will be removed in version 2.0.                                            |  ETA: 00:00:56
> While initializing your connection, use `#request(:basic_auth, ...)` instead.
> See https://lostisland.github.io/faraday/middleware/authentication for more usage info.
Copy link
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @ngouy!

@JenniferMah JenniferMah changed the title Fix deprecation warning on Faraday Fix: deprecation warning on Faraday Sep 1, 2021
@JenniferMah JenniferMah merged commit 3ccb4dc into twilio:main Sep 2, 2021
@JenniferMah JenniferMah changed the title Fix: deprecation warning on Faraday fix: deprecation warning on Faraday Sep 7, 2021
@silikone
Copy link

Thanks to @ngouy for the contribution.

@JenniferMah - Can we please have an update to the dependency spec such that the gem now is no longer resisting Faraday 2.0 and above.

twilio-ruby.gemspec:
spec.add_dependency('faraday', '>= 0.9', '< 2.0')
could now read:
spec.add_dependency('faraday', '>= 0.9', '< 3.0')

/S

@hosamaly hosamaly mentioned this pull request Mar 8, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants